From: Patrick Titiano <ptitiano@baylibre.com>
To: magnus.damm@gmail.com, kuninori.morimoto.gx@renesas.com,
eduardo.valentin@ti.com
Cc: bcousson@baylibre.com, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org, Patrick Titiano <ptitiano@baylibre.com>
Subject: [PATCH 1/2] thermal: rcar-thermal: fix same mask applied twice
Date: Fri, 28 Feb 2014 13:10:03 +0000 [thread overview]
Message-ID: <1393593004-16285-2-git-send-email-ptitiano@baylibre.com> (raw)
In-Reply-To: <1393593004-16285-1-git-send-email-ptitiano@baylibre.com>
Mask is already applied preceding the if statement.
Remove the second mask.
Signed-off-by: Patrick Titiano <ptitiano@baylibre.com>
---
drivers/thermal/rcar_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
index e2bb589..6ea8c5c 100644
--- a/drivers/thermal/rcar_thermal.c
+++ b/drivers/thermal/rcar_thermal.c
@@ -316,7 +316,7 @@ static u32 rcar_thermal_had_changed(struct rcar_thermal_priv *priv, u32 status)
status = (status >> rcar_id_to_shift(priv)) & 0x3;
- if (status & 0x3) {
+ if (status) {
dev_dbg(dev, "thermal%d %s%s\n",
priv->id,
(status & 0x2) ? "Rising " : "",
--
1.8.3.2
next prev parent reply other threads:[~2014-02-28 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 13:10 [PATCH 0/2] thermal: rcar-thermal: minor fixes Patrick Titiano
2014-02-28 13:10 ` Patrick Titiano [this message]
2014-02-28 13:10 ` [PATCH 2/2] thermal: rcar-thermal: update thermal zone only when temperature changes Patrick Titiano
2014-03-02 23:52 ` [PATCH 0/2] thermal: rcar-thermal: minor fixes Kuninori Morimoto
2014-03-03 14:51 ` Zhang Rui
2014-03-05 14:45 ` Patrick Titiano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393593004-16285-2-git-send-email-ptitiano@baylibre.com \
--to=ptitiano@baylibre.com \
--cc=bcousson@baylibre.com \
--cc=eduardo.valentin@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).