From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Date: Tue, 11 Mar 2014 14:27:40 +0000 Subject: Re: [PATCH 1/4] serial: sh-sci: Replace printk() by pr_*() Message-Id: <1394548060.21085.45.camel@joe-AO722> List-Id: References: <1394532680-4264-1-git-send-email-geert@linux-m68k.org> In-Reply-To: <1394532680-4264-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Simon Horman , Laurent Pinchart , linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven On Tue, 2014-03-11 at 11:11 +0100, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > Make banner const while we're at it One thing to consider is to add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt before any #include to make sure all messages are appropriately prefixed by subsystem name. One day, I'd very much like to avoid this by making it the default. http://comments.gmane.org/gmane.linux.kernel/1052288