From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: linux-sh@vger.kernel.org
Subject: Re: [Linux-kernel] [RFC 5/6] drivers: move drivers/sh/pm_runtime.c to drivers/base
Date: Mon, 17 Mar 2014 11:43:23 +0000 [thread overview]
Message-ID: <1395056603.12161.122.camel@xylophone> (raw)
On Mon, 2014-03-17 at 11:15 +0000, Ben Dooks wrote:
> Move the drivers/sh/pm_runtime.c code to drivers/base as it may be of
> use to any systems that need some generic platformbus power management.
[...]
> --- /dev/null
> +++ b/drivers/base/pm_runtime_platform.c
[...]
> +#if defined(CONFIG_ARCH_SHMOBILE_LEGACY) || defined(CONFIG_SH)
> +core_initcall(platformbus_pm_runtime_init);
> +#endif
It looks like this bit is actually needed in patch 2/6. I'm not sure
how these different platform config symbols are used, though.
[...]
> --- a/drivers/sh/pm_runtime.c
> +++ /dev/null
[...]
> -int __init sh_pm_runtime_init(void)
> -{
> - default_pm_on = true;
> - pm_clk_add_notifier(&platform_bus_type, &platform_bus_notifier);
> - return 0;
> -}
[...]
This appears to break SHMobile until 6/6 "ARM: shmobile: change to use
platformbus_pm_runtime_init" is also applied. They should be folded
together.
Ben.
reply other threads:[~2014-03-17 11:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395056603.12161.122.camel@xylophone \
--to=ben.hutchings@codethink.co.uk \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox