From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Date: Tue, 06 May 2014 01:33:20 +0000 Subject: [PATCH v3 2/8] sh, irq: Remove irq_reserve_irq calling Message-Id: <1399340006-31550-3-git-send-email-yinghai@kernel.org> List-Id: References: <1399340006-31550-1-git-send-email-yinghai@kernel.org> In-Reply-To: <1399340006-31550-1-git-send-email-yinghai@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Tony Luck Cc: linux-kernel@vger.kernel.org, Yinghai Lu , Simon Horman , Magnus Damm , linux-sh@vger.kernel.org in sh calling path: register_intc_controller => irq_create_identity_mapping/irq_create_strict_mappins =>irq_alloc_desc: it will set bits on allocate_irq => intc_register_irq => irq_reserve_irq: set bits again so we can kill this irq_reserve_irq calling. -v2: Fix comment style according to Sergei Shtylyov. Signed-off-by: Yinghai Lu Cc: Simon Horman Cc: Magnus Damm Cc: linux-sh@vger.kernel.org Acked-by: Simon Horman --- drivers/sh/intc/core.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/sh/intc/core.c b/drivers/sh/intc/core.c index 8f32a13..d146ce1 100644 --- a/drivers/sh/intc/core.c +++ b/drivers/sh/intc/core.c @@ -80,12 +80,7 @@ static void __init intc_register_irq(struct intc_desc *desc, unsigned int data[2], primary; unsigned long flags; - /* - * Register the IRQ position with the global IRQ map, then insert - * it in to the radix tree. - */ - irq_reserve_irq(irq); - + /* Insert it in to the radix tree. */ raw_spin_lock_irqsave(&intc_big_lock, flags); radix_tree_insert(&d->tree, enum_id, intc_irq_xlate_get(irq)); raw_spin_unlock_irqrestore(&intc_big_lock, flags); -- 1.8.4.5