linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: shmobile: r8a7778: Remove wrapper r8a7778_init_delay()
Date: Thu, 23 Oct 2014 10:25:00 +0000	[thread overview]
Message-ID: <14016389.r3GFE4zLkr@avalon> (raw)
In-Reply-To: <1413548679-12391-1-git-send-email-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Friday 17 October 2014 14:24:38 Geert Uytterhoeven wrote:
> r8a7778_init_delay() just calls shmobile_init_delay(), hence replace
> calls to it by direct calls to shmobile_init_delay().
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm/mach-shmobile/r8a7778.h       | 1 -
>  arch/arm/mach-shmobile/setup-r8a7778.c | 7 +------
>  2 files changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/r8a7778.h
> b/arch/arm/mach-shmobile/r8a7778.h index f4076a50e970a357..4802cee250bea893
> 100644
> --- a/arch/arm/mach-shmobile/r8a7778.h
> +++ b/arch/arm/mach-shmobile/r8a7778.h
> @@ -71,7 +71,6 @@ extern void r8a7778_add_standard_devices_dt(void);
>  extern void r8a7778_add_dt_devices(void);
> 
>  extern void r8a7778_init_late(void);
> -extern void r8a7778_init_delay(void);
>  extern void r8a7778_init_irq_dt(void);
>  extern void r8a7778_clock_init(void);
>  extern void r8a7778_init_irq_extpin(int irlm);
> diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c
> b/arch/arm/mach-shmobile/setup-r8a7778.c index
> 85fe016d6a872a62..97eac8703d4d8ee7 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7778.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> @@ -572,11 +572,6 @@ void __init r8a7778_init_irq_extpin(int irlm)
>  			&irqpin_platform_data, sizeof(irqpin_platform_data));
>  }
> 
> -void __init r8a7778_init_delay(void)
> -{
> -	shmobile_init_delay();
> -}
> -
>  #ifdef CONFIG_USE_OF
>  #define INT2SMSKCR0	0x82288 /* 0xfe782288 */
>  #define INT2SMSKCR1	0x8228c /* 0xfe78228c */
> @@ -608,7 +603,7 @@ static const char *r8a7778_compat_dt[] __initdata = {
>  };
> 
>  DT_MACHINE_START(R8A7778_DT, "Generic R8A7778 (Flattened Device Tree)")
> -	.init_early	= r8a7778_init_delay,
> +	.init_early	= shmobile_init_delay,
>  	.init_irq	= r8a7778_init_irq_dt,
>  	.init_late	= shmobile_init_late,
>  	.dt_compat	= r8a7778_compat_dt,

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2014-10-23 10:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 12:24 [PATCH 1/2] ARM: shmobile: r8a7778: Remove wrapper r8a7778_init_delay() Geert Uytterhoeven
2014-10-23 10:25 ` Laurent Pinchart [this message]
2014-10-24  2:08 ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2014-10-29  5:00 [GIT PULL] Renesas ARM Based SoC Soc Cleanups for v3.19 Simon Horman
2014-10-29  5:00 ` [PATCH 1/2] ARM: shmobile: r8a7778: Remove wrapper r8a7778_init_delay() Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14016389.r3GFE4zLkr@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).