[PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[Yoshihiro Kaneko]

This series is against master branch of linuxtv.org/media_tree.git.

Koji Matsuoka (2):
  media: soc_camera: rcar_vin: Add r8a7794 device support
  media: soc_camera: rcar_vin: Add r8a7793 device support

 drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
1.9.1

[PATCH 1/2] media: soc_camera: rcar_vin: Add r8a7794 device support

[Yoshihiro Kaneko]

From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>

Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
 drivers/media/platform/soc_camera/rcar_vin.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index bf3588f..224604d0 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -1887,6 +1887,7 @@ MODULE_DEVICE_TABLE(of, rcar_vin_of_table);
 #endif
 
 static struct platform_device_id rcar_vin_id_table[] = {
+	{ "r8a7794-vin",  RCAR_GEN2 },
 	{ "r8a7791-vin",  RCAR_GEN2 },
 	{ "r8a7790-vin",  RCAR_GEN2 },
 	{ "r8a7779-vin",  RCAR_H1 },
-- 
1.9.1

[PATCH 2/2] media: soc_camera: rcar_vin: Add r8a7793 device support

[Yoshihiro Kaneko]

From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>

Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
 drivers/media/platform/soc_camera/rcar_vin.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index 224604d0..55f99aa 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -1888,6 +1888,7 @@ MODULE_DEVICE_TABLE(of, rcar_vin_of_table);
 
 static struct platform_device_id rcar_vin_id_table[] = {
 	{ "r8a7794-vin",  RCAR_GEN2 },
+	{ "r8a7793-vin",  RCAR_GEN2 },
 	{ "r8a7791-vin",  RCAR_GEN2 },
 	{ "r8a7790-vin",  RCAR_GEN2 },
 	{ "r8a7779-vin",  RCAR_H1 },
-- 
1.9.1

Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[Simon Horman]

[CC Mauro Carvalho Chehab]

On Tue, Oct 14, 2014 at 04:20:22PM +0900, Yoshihiro Kaneko wrote:
> This series is against master branch of linuxtv.org/media_tree.git.
> 
> Koji Matsuoka (2):
>   media: soc_camera: rcar_vin: Add r8a7794 device support
>   media: soc_camera: rcar_vin: Add r8a7793 device support
> 
>  drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
>  1 file changed, 2 insertions(+)

Acked-by: Simon Horman <horms+renesas@verge.net.au>

If the series needs reposting to a different CC list -
e.g. including Mauro - please let Kaneko-san or myself know.

Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[Guennadi Liakhovetski]

Hello,

Thanks for the patches. Could you please fold these two into one - they 
really don't deserve to be separated. As for your other series - patches 
there look mostly good - from just a formal review. If you don't mind, 
I'll adjust a couple of cosmetic issues like missing curly braces in 

	if (a)
		x();
	else {
		y();
		z();
	}

or multiline comments or similar minor things.

Thanks
Guennadi

On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote:

> This series is against master branch of linuxtv.org/media_tree.git.
> 
> Koji Matsuoka (2):
>   media: soc_camera: rcar_vin: Add r8a7794 device support
>   media: soc_camera: rcar_vin: Add r8a7793 device support
> 
>  drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> -- 
> 1.9.1
> 

Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[Simon Horman]

Hi Guennadi,

On Thu, Oct 16, 2014 at 10:27:13PM +0200, Guennadi Liakhovetski wrote:
> Hello,
> 
> Thanks for the patches. Could you please fold these two into one - they 
> really don't deserve to be separated.

Thanks. Kaneko-san could you squash these patches and repost?

> As for your other series - patches 
> there look mostly good - from just a formal review. If you don't mind, 
> I'll adjust a couple of cosmetic issues like missing curly braces in 
> 
> 	if (a)
> 		x();
> 	else {
> 		y();
> 		z();
> 	}
> 
> or multiline comments or similar minor things.

Feel free to make any minor updates.

> Thanks
> Guennadi
> 
> On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote:
> 
> > This series is against master branch of linuxtv.org/media_tree.git.
> > 
> > Koji Matsuoka (2):
> >   media: soc_camera: rcar_vin: Add r8a7794 device support
> >   media: soc_camera: rcar_vin: Add r8a7793 device support
> > 
> >  drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > -- 
> > 1.9.1
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support

[Yoshihiro Kaneko]

2014-10-17 15:02 GMT+09:00 Simon Horman <horms@verge.net.au>:
> Hi Guennadi,
>
> On Thu, Oct 16, 2014 at 10:27:13PM +0200, Guennadi Liakhovetski wrote:
>> Hello,
>>
>> Thanks for the patches. Could you please fold these two into one - they
>> really don't deserve to be separated.
>
> Thanks. Kaneko-san could you squash these patches and repost?

Sure, will do.

>
>> As for your other series - patches
>> there look mostly good - from just a formal review. If you don't mind,
>> I'll adjust a couple of cosmetic issues like missing curly braces in
>>
>>       if (a)
>>               x();
>>       else {
>>               y();
>>               z();
>>       }
>>
>> or multiline comments or similar minor things.
>
> Feel free to make any minor updates.
>
>> Thanks
>> Guennadi
>>
>> On Tue, 14 Oct 2014, Yoshihiro Kaneko wrote:
>>
>> > This series is against master branch of linuxtv.org/media_tree.git.
>> >
>> > Koji Matsuoka (2):
>> >   media: soc_camera: rcar_vin: Add r8a7794 device support
>> >   media: soc_camera: rcar_vin: Add r8a7793 device support
>> >
>> >  drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> >
>> > --
>> > 1.9.1
>> >
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>