From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
To: linux-media@vger.kernel.org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: [PATCH] media: soc_camera: rcar_vin: Fix alignment of clipping size
Date: Fri, 31 Oct 2014 09:10:10 +0000 [thread overview]
Message-ID: <1414746610-23194-1-git-send-email-ykaneko0929@gmail.com> (raw)
In-Reply-To: <1414746565-23142-1-git-send-email-ykaneko0929@gmail.com>
From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Since the Start Line Pre-Clip register, the Start Pixel Pre-Clip
register and the End Line Post-Clip register do not have restriction
of H/W to a setting value, the processing of alignment is unnecessary.
This patch corrects so that processing of alignment is not performed.
However, the End Pixel Post-Clip register has restriction
of H/W which must be an even number value at the time of the
output of YCbCr-422 format. By this patch, the processing of
alignment to an even number value is added on the above-mentioned
conditions.
The variable set to a register is as follows.
- Start Line Pre-Clip register
cam->vin_top
- Start Pixel Pre-Clip register
cam->vin_left
- End Line Post-Clip register
pix->height
- End Pixel Post-Clip register
pix->width
Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
drivers/media/platform/soc_camera/rcar_vin.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
index d3d2f7d..1934e15 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -1558,8 +1558,8 @@ static int rcar_vin_set_crop(struct soc_camera_device *icd,
cam->width = mf.width;
cam->height = mf.height;
- cam->vin_left = rect->left & ~1;
- cam->vin_top = rect->top & ~1;
+ cam->vin_left = rect->left;
+ cam->vin_top = rect->top;
/* Use VIN cropping to crop to the new window. */
ret = rcar_vin_set_rect(icd);
@@ -1761,8 +1761,18 @@ static int rcar_vin_try_fmt(struct soc_camera_device *icd,
}
/* FIXME: calculate using depth and bus width */
- v4l_bound_align_image(&pix->width, 2, VIN_MAX_WIDTH, 1,
- &pix->height, 4, VIN_MAX_HEIGHT, 2, 0);
+ /*
+ * When performing a YCbCr-422 format output, even if it performs
+ * odd number clipping by pixel post clip processing, it is outputted
+ * to a memory per even pixels.
+ */
+ if ((pixfmt = V4L2_PIX_FMT_NV16) || (pixfmt = V4L2_PIX_FMT_YUYV) ||
+ (pixfmt = V4L2_PIX_FMT_UYVY))
+ v4l_bound_align_image(&pix->width, 5, VIN_MAX_WIDTH, 1,
+ &pix->height, 2, VIN_MAX_HEIGHT, 0, 0);
+ else
+ v4l_bound_align_image(&pix->width, 5, VIN_MAX_WIDTH, 0,
+ &pix->height, 2, VIN_MAX_HEIGHT, 0, 0);
width = pix->width;
height = pix->height;
--
1.9.1
next prev parent reply other threads:[~2014-10-31 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 9:09 [PATCH] media: soc_camera: rcar_vin: Fix interrupt enable in progressive Yoshihiro Kaneko
2014-10-31 9:10 ` Yoshihiro Kaneko [this message]
2014-10-31 13:40 ` [PATCH] media: soc_camera: rcar_vin: Fix alignment of clipping size Sergei Shtylyov
2014-11-20 1:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414746610-23194-1-git-send-email-ykaneko0929@gmail.com \
--to=ykaneko0929@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).