From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: dmaengine@vger.kernel.org, linux-pm@vger.kernel.org,
linux-sh@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2] dmaengine: shdma: Runtime-resume device in .shutdown()
Date: Mon, 05 Jan 2015 10:46:29 +0000 [thread overview]
Message-ID: <1420454789-11547-1-git-send-email-geert+renesas@glider.be> (raw)
During system reboot, the sh-dma-engine device may be runtime-suspended,
causing a crash:
Unhandled fault: imprecise external abort (0x1406) at 0x0002c02c
Internal error: : 1406 [#1] SMP ARM
...
PC is at sh_dmae_ctl_stop+0x28/0x64
LR is at sh_dmae_ctl_stop+0x24/0x64
If the sh-dma-engine is runtime-suspended, its module clock is turned
off, and its registers cannot be accessed.
To fix this, change the driver's .shutdown() callback:
- If the device is runtime suspended, do nothing,
- Else, explicitly runtime-resume the device, to avoid the device from
being suspended while sh_dmae_ctl_stop() is being executed.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Do nothing if we're runtime suspended.
---
drivers/dma/sh/shdmac.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index aec8a84784a469d7..2de30e8e7d9290b9 100644
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -585,7 +585,13 @@ static void sh_dmae_chan_remove(struct sh_dmae_device *shdev)
static void sh_dmae_shutdown(struct platform_device *pdev)
{
struct sh_dmae_device *shdev = platform_get_drvdata(pdev);
+
+ if (pm_runtime_suspended(&pdev->dev))
+ return;
+
+ pm_runtime_get_sync(&pdev->dev);
sh_dmae_ctl_stop(shdev);
+ pm_runtime_put(&pdev->dev);
}
static int sh_dmae_runtime_suspend(struct device *dev)
--
1.9.1
next reply other threads:[~2015-01-05 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 10:46 Geert Uytterhoeven [this message]
2015-01-29 14:46 ` [PATCH v2] dmaengine: shdma: Runtime-resume device in .shutdown() Geert Uytterhoeven
2015-01-30 9:46 ` Krzysztof Kozlowski
2015-01-30 10:04 ` Geert Uytterhoeven
2015-02-02 9:35 ` Ulf Hansson
2015-02-04 2:08 ` Vinod Koul
2015-02-04 9:35 ` Ulf Hansson
2015-02-04 9:56 ` Geert Uytterhoeven
2015-02-04 10:56 ` Ulf Hansson
2015-02-05 20:17 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420454789-11547-1-git-send-email-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).