* [PATCH] spi: sh-msiof: Use async pm_runtime_put() in sh_msiof_spi_setup()
@ 2015-01-07 15:37 Geert Uytterhoeven
2015-01-07 17:30 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-01-07 15:37 UTC (permalink / raw)
To: Mark Brown
Cc: Hisashi Nakamura, Yoshihiro Kaneko, Sergei Shtylyov,
linux-spi-u79uwXL29TY76Z2rM5mHXA, linux-sh-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Geert Uytterhoeven
There's no need to use the synchronous version.
Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 015760563ec77bf1 ("spi: sh-msiof: Add runtime PM lock in initializing")
---
Please note that 015760563ec77bf1 is marked for stable.
drivers/spi/spi-sh-msiof.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 3f7ea2d49456e754..050e9188df1b309c 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -546,7 +546,7 @@ static int sh_msiof_spi_setup(struct spi_device *spi)
gpio_set_value(spi->cs_gpio, !(spi->mode & SPI_CS_HIGH));
- pm_runtime_put_sync(&p->pdev->dev);
+ pm_runtime_put(&p->pdev->dev);
return 0;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] spi: sh-msiof: Use async pm_runtime_put() in sh_msiof_spi_setup()
2015-01-07 15:37 [PATCH] spi: sh-msiof: Use async pm_runtime_put() in sh_msiof_spi_setup() Geert Uytterhoeven
@ 2015-01-07 17:30 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-01-07 17:30 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Hisashi Nakamura, Yoshihiro Kaneko, Sergei Shtylyov, linux-spi,
linux-sh, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 472 bytes --]
On Wed, Jan 07, 2015 at 04:37:25PM +0100, Geert Uytterhoeven wrote:
> There's no need to use the synchronous version.
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Fixes: 015760563ec77bf1 ("spi: sh-msiof: Add runtime PM lock in initializing")
> ---
> Please note that 015760563ec77bf1 is marked for stable.
Sure, but this is just an optimisation really. Anyway, applied.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-07 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 15:37 [PATCH] spi: sh-msiof: Use async pm_runtime_put() in sh_msiof_spi_setup() Geert Uytterhoeven
2015-01-07 17:30 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).