From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Hutchings Date: Thu, 11 Jun 2015 01:47:17 +0000 Subject: Re: [PATCH v2 5/6] ARM: shmobile: lager: Set clock rates for SDHI Message-Id: <1433987237.12074.95.camel@codethink.co.uk> List-Id: References: <1433892104.12074.49.camel@codethink.co.uk> <1433892257.12074.54.camel@codethink.co.uk> <87r3pjcabj.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87r3pjcabj.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kuninori Morimoto Cc: Ian Molton , linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@lists.codethink.co.uk, Sergei Shtylyov , Simon Horman On Thu, 2015-06-11 at 01:20 +0000, Kuninori Morimoto wrote: > Hi Ben > > Sorry for my small amount of question, but I would like to ask 1 thing > > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts > > index aaa4f258e279..5f68e53c58ae 100644 > > --- a/arch/arm/boot/dts/r8a7790-lager.dts > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > > @@ -488,6 +488,9 @@ > > pinctrl-0 = <&sdhi0_pins>; > > pinctrl-names = "default"; > > > > + assigned-clocks = <&mstp3_clks R8A7790_CLK_SDHI0>; > > + assigned-clock-rates = <156000000>; > > Can we use "max-frequency" here ? > tmio/sh_mobile_sdhi have tmio_mmc_clk_update/sh_mobile_sdhi_clk_enable The purpose of these properties is to configure the frequency of the clock supplied to the SDHI block. sh_mobile_sdhi has no code to do that but these properties are handled by the clock core. The max-frequency property tells the MMC core the maximum clock frequency that the host can run the SD bus at, but anyway tmio_mmc and sh_mobile_sdhi seem to always override it. Ben.