From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
To: linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: [PATCH/RFC] serial: sh-sci: Fix issue of frequent rx_full interrupt
Date: Sun, 14 Jun 2015 17:26:26 +0000 [thread overview]
Message-ID: <1434302786-31162-1-git-send-email-ykaneko0929@gmail.com> (raw)
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
When the receive FIFO is not read in PIO transfer, rx_full interrupt
occurs frequently. This patch avoids it by discarding the receive FIFO.
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
tree.
drivers/tty/serial/sh-sci.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index b74a644..4ec3c32 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -121,6 +121,8 @@ struct sci_port {
#endif
struct notifier_block freq_transition;
+
+ u64 rxfull_time;
};
/* Function prototypes */
@@ -690,12 +692,26 @@ static void sci_receive_chars(struct uart_port *port)
return;
while (1) {
+ int rxfill = sci_rxfill(port);
+ u64 now = get_jiffies_64();
/* Don't copy more bytes than there is room for in the buffer */
- count = tty_buffer_request_room(tport, sci_rxfill(port));
+ count = tty_buffer_request_room(tport, rxfill);
/* If for any reason we can't copy more data, we're done! */
- if (count = 0)
+ if (count = 0) {
+ int n;
+ /* discarded bytes in RX-FIFO */
+ for (n = 0; n < rxfill; n++)
+ serial_port_in(port, SCxRDR);
+ if (rxfill > 0 &&
+ time_after64(now, sci_port->rxfull_time + (5*HZ))) {
+ sci_port->rxfull_time = now;
+ dev_warn(port->dev,
+ "RX-FIFO isn't read, so %d bytes is discarded.\n",
+ rxfill);
+ }
break;
+ }
if (port->type = PORT_SCI) {
char c = serial_port_in(port, SCxRDR);
@@ -2342,6 +2358,8 @@ static int sci_init_single(struct platform_device *dev,
dev_dbg(port->dev, "DMA tx %d, rx %d\n",
p->dma_slave_tx, p->dma_slave_rx);
+ sci_port->rxfull_time = get_jiffies_64();
+
return 0;
}
--
1.9.1
next reply other threads:[~2015-06-14 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 17:26 Yoshihiro Kaneko [this message]
2015-07-15 11:26 ` [PATCH/RFC] serial: sh-sci: Fix issue of frequent rx_full interrupt Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1434302786-31162-1-git-send-email-ykaneko0929@gmail.com \
--to=ykaneko0929@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).