[PATCH 1/6] reset: Add renesas,rst DT bindings.

[PATCH 1/6] reset: Add renesas,rst DT bindings.

[Geert Uytterhoeven]

Add DT bindings for the Renesas R-Car Reset Controller

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 .../devicetree/bindings/reset/renesas,rst.txt      | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/reset/renesas,rst.txt

diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt b/Documentation/devicetree/bindings/reset/renesas,rst.txt
new file mode 100644
index 0000000000000000..aabf8dc6bce86ffc
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt
@@ -0,0 +1,28 @@
+DT bindings for the Renesas R-Car Reset Controller
+
+The R-Car Reset Controller provides reset control, and implements the following
+functions:
+  - Register-based reset control for the various CPU cores,
+  - Latching of the levels on mode pins when PRESET# is negated,
+  - Mode monitoring register,
+  - Boot address registers for the various CPU cores.
+
+
+Required properties:
+  - compatible: Should be "renesas,rst-<soctype>", and "syscon".
+		Examples with soctypes are:
+		  - "renesas,rst-r8a7790" (R-Car H2)
+		  - "renesas,rst-r8a7791" (R-Car M2-W)
+		  - "renesas,rst-r8a7792" (R-Car V2H
+		  - "renesas,rst-r8a7793" (R-Car M2-N)
+		  - "renesas,rst-r8a7794" (R-Car E2)
+		  - "renesas,rst-r8a7795" (R-Car H3)
+  - reg: Address start and address range for the device.
+
+
+Example:
+
+	rst: reset-controller@e6160000 {
+		compatible = "renesas,rst-r8a7795", "syscon";
+		reg = <0 0xe6160000 0 0x0200>;
+	};
-- 
1.9.1

Re: [PATCH 1/6] reset: Add renesas,rst DT bindings.

[Magnus Damm]

Hi Geert,

On Wed, Sep 2, 2015 at 12:12 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Add DT bindings for the Renesas R-Car Reset Controller
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, this looks very good to me!
Acked-by: Magnus Damm <damm+renesas@opensource.se>

Re: [PATCH 1/6] reset: Add renesas,rst DT bindings.

[Philipp Zabel]

Hi Geert,

Am Dienstag, den 01.09.2015, 17:12 +0200 schrieb Geert Uytterhoeven:
> Add DT bindings for the Renesas R-Car Reset Controller
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../devicetree/bindings/reset/renesas,rst.txt      | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/renesas,rst.txt
> 
> diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt b/Documentation/devicetree/bindings/reset/renesas,rst.txt
> new file mode 100644
> index 0000000000000000..aabf8dc6bce86ffc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt
> @@ -0,0 +1,28 @@
> +DT bindings for the Renesas R-Car Reset Controller
> +
> +The R-Car Reset Controller provides reset control, and implements the following
> +functions:
> +  - Register-based reset control for the various CPU cores,

Could any of these ever be used by other device tree nodes?
If so, the reset-controller node should contain the #reset-cells
property.

regards
Philipp

Re: [PATCH 1/6] reset: Add renesas,rst DT bindings.

[Geert Uytterhoeven]

Hi Philipp,

On Wed, Sep 2, 2015 at 2:40 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Am Dienstag, den 01.09.2015, 17:12 +0200 schrieb Geert Uytterhoeven:
>> Add DT bindings for the Renesas R-Car Reset Controller
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>  .../devicetree/bindings/reset/renesas,rst.txt      | 28 ++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/reset/renesas,rst.txt
>>
>> diff --git a/Documentation/devicetree/bindings/reset/renesas,rst.txt b/Documentation/devicetree/bindings/reset/renesas,rst.txt
>> new file mode 100644
>> index 0000000000000000..aabf8dc6bce86ffc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/reset/renesas,rst.txt
>> @@ -0,0 +1,28 @@
>> +DT bindings for the Renesas R-Car Reset Controller
>> +
>> +The R-Car Reset Controller provides reset control, and implements the following
>> +functions:
>> +  - Register-based reset control for the various CPU cores,
>
> Could any of these ever be used by other device tree nodes?
> If so, the reset-controller node should contain the #reset-cells
> property.

Possibly. That would require defining a format for the reset specifier, which
we haven't done yet (one or two numbers?).
There can be multiple reset registers, handling multiple CPU cores each,
depending on the SoC.

For now we're interested in the mode monitoring feature only, for obtaining
the values of the boot mode pins.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds