linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: hamzahfrq.sub@gmail.com
To: linux-sh@vger.kernel.org
Subject: [PATCH v3 3/6] dma: rcar-dma: check if complete DMA packet received but not processed
Date: Tue, 29 Sep 2015 20:44:45 +0000	[thread overview]
Message-ID: <1443559488-2416-4-git-send-email-hamzahfrq.sub@gmail.com> (raw)

From: Muhammad Hamza Farooq <mfarooq@visteon.com>

At high speeds, DMA interrupts come very fast. If there's an interrupt
pending before previous is handled, this method can help return actual
status of the DMA transaction by reading the hardware flag

Signed-off-by: Muhammad Hamza Farooq <mfarooq@visteon.com>
---
 drivers/dma/sh/rcar-dmac.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
index c7cd4ed..6c806d0 100644
--- a/drivers/dma/sh/rcar-dmac.c
+++ b/drivers/dma/sh/rcar-dmac.c
@@ -314,6 +314,14 @@ static bool rcar_dmac_chan_is_busy(struct rcar_dmac_chan *chan)
 	return (chcr & (RCAR_DMACHCR_DE | RCAR_DMACHCR_TE)) = RCAR_DMACHCR_DE;
 }
 
+/* Transfer completed but not yet handled */
+static bool rcar_dmac_last_tx_complete(struct rcar_dmac_chan *chan)
+{
+	u32 chcr = rcar_dmac_chan_read(chan, RCAR_DMACHCR);
+
+	return (chcr & RCAR_DMACHCR_TE) = RCAR_DMACHCR_TE;
+}
+
 static void rcar_dmac_chan_start_xfer(struct rcar_dmac_chan *chan)
 {
 	struct rcar_dmac_desc *desc = chan->desc.running;
@@ -1238,6 +1246,10 @@ static enum dma_status rcar_dmac_tx_status(struct dma_chan *chan,
 	unsigned long flags;
 	unsigned int residue;
 
+	/* Interrupt not yet serviced */
+	if (rcar_dmac_last_tx_complete(rchan))
+		return DMA_COMPLETE;
+
 	status = dma_cookie_status(chan, cookie, txstate);
 	if (status = DMA_COMPLETE || !txstate)
 		return status;
-- 
1.9.1


             reply	other threads:[~2015-09-29 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-29 20:44 hamzahfrq.sub [this message]
2015-10-12 15:18 ` [PATCH v3 3/6] dma: rcar-dma: check if complete DMA packet received but not processed Vinod Koul
2015-10-15 16:15 ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443559488-2416-4-git-send-email-hamzahfrq.sub@gmail.com \
    --to=hamzahfrq.sub@gmail.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).