From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Cc: Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/4] spi: spi-coldfire-qspi: enable RuntimePM before registering to the core
Date: Fri, 09 Oct 2015 06:54:53 +0000 [thread overview]
Message-ID: <1444373693-2372-4-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1444373693-2372-1-git-send-email-wsa@the-dreams.de>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
The core may register clients attached to this master which may use
funtionality from the master. So, RuntimePM must be enabled before, otherwise
this will fail.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Not tested on HW. Found by code review.
drivers/spi/spi-coldfire-qspi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
index 688956ff5095c2..2c5fe795bb5e59 100644
--- a/drivers/spi/spi-coldfire-qspi.c
+++ b/drivers/spi/spi-coldfire-qspi.c
@@ -420,13 +420,13 @@ static int mcfqspi_probe(struct platform_device *pdev)
master->auto_runtime_pm = true;
platform_set_drvdata(pdev, master);
+ pm_runtime_enable(&pdev->dev);
status = devm_spi_register_master(&pdev->dev, master);
if (status) {
dev_dbg(&pdev->dev, "spi_register_master failed\n");
goto fail2;
}
- pm_runtime_enable(&pdev->dev);
dev_info(&pdev->dev, "Coldfire QSPI bus driver\n");
--
2.1.4
next prev parent reply other threads:[~2015-10-09 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 6:54 [PATCH 1/4] i2c: designware-platdrv: enable RuntimePM before registering to the core Wolfram Sang
2015-10-09 6:54 ` [PATCH 2/4] i2c: rcar: " Wolfram Sang
2015-10-09 8:45 ` Geert Uytterhoeven
2015-10-09 9:21 ` Wolfram Sang
2015-10-09 6:54 ` [PATCH 3/4] i2c: s3c2410: " Wolfram Sang
2015-10-09 6:54 ` Wolfram Sang [this message]
2015-10-09 11:31 ` [PATCH 4/4] spi: spi-coldfire-qspi: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444373693-2372-4-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).