From: Wolfram Sang <wsa@the-dreams.de>
To: linux-i2c@vger.kernel.org
Cc: linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [RFC 2/9] i2c: add generic routine to parse DT timing information
Date: Thu, 26 Nov 2015 22:59:10 +0000 [thread overview]
Message-ID: <1448578757-12613-3-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1448578757-12613-1-git-send-email-wsa@the-dreams.de>
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
Inspired from the i2c-rk3x driver, thanks guys!
FIXME: add documentation
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-core.c | 34 ++++++++++++++++++++++++++++++++++
include/linux/i2c.h | 15 +++++++++++++++
2 files changed, 49 insertions(+)
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 040af5cc8143f1..7543fec4f65b61 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -1438,6 +1438,40 @@ static void of_i2c_register_devices(struct i2c_adapter *adap)
}
}
+void of_i2c_parse_timings(struct device_node *node, struct i2c_timings *t, bool use_defaults)
+{
+ memset(t, 0, sizeof(*t));
+
+ if (of_property_read_u32(node, "clock-frequency", &t->bus_freq) && use_defaults)
+ t->bus_freq = 100000;
+
+ /*
+ * Read rise and fall time from device tree. If not available, use
+ * the default maximum timing from the specification.
+ */
+ if (of_property_read_u32(node, "i2c-scl-rising-time-ns", &t->scl_rise_ns) && use_defaults) {
+ if (t->bus_freq <= 100000)
+ t->scl_rise_ns = 1000;
+ else if (t->bus_freq <= 400000)
+ t->scl_rise_ns = 300;
+ else
+ t->scl_rise_ns = 120;
+ }
+
+ if (of_property_read_u32(node, "i2c-scl-falling-time-ns", &t->scl_fall_ns) && use_defaults) {
+ if (t->bus_freq <= 400000)
+ t->scl_fall_ns = 300;
+ else
+ t->scl_fall_ns = 120;
+ }
+
+ of_property_read_u32(node, "i2c-scl-internal-delay-ns", &t->scl_int_delay_ns);
+
+ if (of_property_read_u32(node, "i2c-sda-falling-time-ns", &t->sda_fall_ns) && use_defaults)
+ t->sda_fall_ns = t->scl_fall_ns;
+}
+EXPORT_SYMBOL_GPL(of_i2c_parse_timings);
+
static int of_dev_node_match(struct device *dev, void *data)
{
return dev->of_node = data;
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 768063baafbf5e..ca28c104ac5fb6 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -413,6 +413,15 @@ struct i2c_algorithm {
#endif
};
+/* FIXME: Add docs */
+struct i2c_timings {
+ u32 bus_freq;
+ u32 scl_rise_ns;
+ u32 scl_fall_ns;
+ u32 scl_int_delay_ns;
+ u32 sda_fall_ns;
+};
+
/**
* struct i2c_bus_recovery_info - I2C bus recovery information
* @recover_bus: Recover routine. Either pass driver's recover_bus() routine, or
@@ -644,6 +653,8 @@ extern struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node *node)
/* must call i2c_put_adapter() when done with returned i2c_adapter device */
struct i2c_adapter *of_get_i2c_adapter_by_node(struct device_node *node);
+
+void of_i2c_parse_timings(struct device_node *node, struct i2c_timings *t, bool use_defaults);
#else
static inline struct i2c_client *of_find_i2c_device_by_node(struct device_node *node)
@@ -660,6 +671,10 @@ static inline struct i2c_adapter *of_get_i2c_adapter_by_node(struct device_node
{
return NULL;
}
+
+static inline void of_i2c_parse_timings(struct device_node *node, struct i2c_timings *t, bool use_defaults)
+{
+}
#endif /* CONFIG_OF */
#endif /* _LINUX_I2C_H */
--
2.1.4
next prev parent reply other threads:[~2015-11-26 22:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 22:59 [RFC 0/9] i2c: add generic support for timing parameters Wolfram Sang
2015-11-26 22:59 ` [RFC 1/9] i2c: document generic DT bindings " Wolfram Sang
2015-11-26 22:59 ` Wolfram Sang [this message]
2015-11-26 22:59 ` [RFC 3/9] i2c: rcar: refactor probe function a little Wolfram Sang
2015-11-26 22:59 ` [RFC 4/9] i2c: rcar: switch to i2c generic dt parsing Wolfram Sang
2015-11-26 22:59 ` [RFC 5/9] i2c: rcar: honor additional i2c timings from DT Wolfram Sang
2015-11-27 8:04 ` Geert Uytterhoeven
2015-12-03 10:59 ` Wolfram Sang
2015-11-26 22:59 ` [RFC 6/9] ARM: shmobile: r8a7790: dtsi: add internal delay for i2c IPs Wolfram Sang
2015-11-26 22:59 ` [RFC 7/9] ARM: shmobile: r8a7791: " Wolfram Sang
2015-11-27 11:58 ` Sergei Shtylyov
2015-11-26 22:59 ` [RFC 8/9] ARM: shmobile: r8a7794: " Wolfram Sang
2015-11-26 22:59 ` [RFC 9/9] arm64: renesas: r8a7795: " Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448578757-12613-3-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).