linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: shmobile: armadillo800eva dts: Correct extal1 frequency to 24 MHz
@ 2015-12-18 10:51 Geert Uytterhoeven
  2016-01-05 13:37 ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2015-12-18 10:51 UTC (permalink / raw)
  To: linux-sh

On r8a7740/armadillo, actual clock rates are ca. 4% lower than reported
by /sys/kernel/debug/clk/clk_summary. Correct the extal1 frequency from
25 MHz to 24 MHz to fix this.

This matches the Armadillo-800 EVA Product Manual, which claims the main
crystal runs at 24 MHz, and the old legacy/reference board code.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 5845e4e6c700568f..13d27e3985378552 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -180,7 +180,7 @@
 };
 
 &extal1_clk {
-	clock-frequency = <25000000>;
+	clock-frequency = <24000000>;
 };
 &extal2_clk {
 	clock-frequency = <48000000>;
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: shmobile: armadillo800eva dts: Correct extal1 frequency to 24 MHz
  2015-12-18 10:51 [PATCH] ARM: shmobile: armadillo800eva dts: Correct extal1 frequency to 24 MHz Geert Uytterhoeven
@ 2016-01-05 13:37 ` Geert Uytterhoeven
  2016-01-18  1:55   ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-01-05 13:37 UTC (permalink / raw)
  To: linux-sh

On Fri, Dec 18, 2015 at 11:51 AM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> On r8a7740/armadillo, actual clock rates are ca. 4% lower than reported
> by /sys/kernel/debug/clk/clk_summary. Correct the extal1 frequency from
> 25 MHz to 24 MHz to fix this.
>
> This matches the Armadillo-800 EVA Product Manual, which claims the main
> crystal runs at 24 MHz, and the old legacy/reference board code.

Ping? I think we want this applied to -stable and -ltsi, too.

> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> index 5845e4e6c700568f..13d27e3985378552 100644
> --- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> +++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
> @@ -180,7 +180,7 @@
>  };
>
>  &extal1_clk {
> -       clock-frequency = <25000000>;
> +       clock-frequency = <24000000>;
>  };
>  &extal2_clk {
>         clock-frequency = <48000000>;
> --
> 1.9.1

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: shmobile: armadillo800eva dts: Correct extal1 frequency to 24 MHz
  2016-01-05 13:37 ` Geert Uytterhoeven
@ 2016-01-18  1:55   ` Simon Horman
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2016-01-18  1:55 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Geert Uytterhoeven, linux-renesas-soc, Linux-sh list

On Tue, Jan 05, 2016 at 02:37:07PM +0100, Geert Uytterhoeven wrote:
> On Fri, Dec 18, 2015 at 11:51 AM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > On r8a7740/armadillo, actual clock rates are ca. 4% lower than reported
> > by /sys/kernel/debug/clk/clk_summary. Correct the extal1 frequency from
> > 25 MHz to 24 MHz to fix this.
> >
> > This matches the Armadillo-800 EVA Product Manual, which claims the main
> > crystal runs at 24 MHz, and the old legacy/reference board code.
> 
> Ping? I think we want this applied to -stable and -ltsi, too.

Sorry for letting this slip through the cracks.

I have queued up the following as a fix for v4.5.

From: Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH] ARM: dts: armadillo800eva Correct extal1 frequency to 24 MHz

On r8a7740/armadillo, actual clock rates are ca. 4% lower than reported
by /sys/kernel/debug/clk/clk_summary. Correct the extal1 frequency from
25 MHz to 24 MHz to fix this.

This matches the Armadillo-800 EVA Product Manual, which claims the main
crystal runs at 24 MHz, and the old legacy/reference board code.

Fixes: 25aa7ba3fdfb ("ARM: shmobile: armadillo800eva: Sync DTS")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
index 105d9c95de4a..5c76dcc89df5 100644
--- a/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
+++ b/arch/arm/boot/dts/r8a7740-armadillo800eva.dts
@@ -180,7 +180,7 @@
 };
 
 &extal1_clk {
-	clock-frequency = <25000000>;
+	clock-frequency = <24000000>;
 };
 &extal2_clk {
 	clock-frequency = <48000000>;
-- 
2.1.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-01-18  1:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-18 10:51 [PATCH] ARM: shmobile: armadillo800eva dts: Correct extal1 frequency to 24 MHz Geert Uytterhoeven
2016-01-05 13:37 ` Geert Uytterhoeven
2016-01-18  1:55   ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).