linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: linux-sh@vger.kernel.org
Subject: [PATCH 0/3] ARM: shmobile: Fix loop-based delays
Date: Mon, 11 Jan 2016 18:41:11 +0000	[thread overview]
Message-ID: <1452537674-20006-1-git-send-email-geert+renesas@glider.be> (raw)

	Hi Simon, Magnus,

I accidentally noticed that on r8a7740/armadillo, "mdelay(1000)" took
only 333 ms with my personal config, while it took 3675 ms with
shmobile_defconfig.

Finding out why brought me an animating journey through obscure code
and kernel config options...

Apparently loop-based delays may complete early on all shmobile SoCs,
which may lead to subtle driver failures. Fortunately(?) this was
mitigated by:
  1. the ARM arch timer on Cortex A7 and A15, which is used instead of
     loop-based delays if available,
  2. shmobile_defconfig having CONFIG_CPU_BPREDICT_DISABLE enabled
     (why?), which makes loops up to 16 times slower.

This patch series fixes both, and removes a related check for Cortex A8
CPU cores, which are no longer supported anyway.

Tested on a collection of shmobile SoCs with Cortex A7, A9, and A15 CPU
cores, with some verification on BeagleBone Black (Cortex A8).

Thanks for applying!

Geert Uytterhoeven (3):
  ARM: shmobile: timer: Fix preset_lpj leading to too short delays
  ARM: shmobile: timer: Drop support for Cortex A8
  ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE

 arch/arm/configs/shmobile_defconfig |  1 -
 arch/arm/mach-shmobile/timer.c      | 26 +++++++++-----------------
 2 files changed, 9 insertions(+), 18 deletions(-)

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2016-01-11 18:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-11 18:41 Geert Uytterhoeven [this message]
2016-01-11 18:41 ` [PATCH 1/3] ARM: shmobile: timer: Fix preset_lpj leading to too short delays Geert Uytterhoeven
2016-01-18  1:42   ` Simon Horman
2016-01-11 18:41 ` [PATCH 2/3] ARM: shmobile: timer: Drop support for Cortex A8 Geert Uytterhoeven
2016-01-18  1:45   ` Simon Horman
2016-01-11 18:41 ` [PATCH 3/3] ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE Geert Uytterhoeven
2016-01-18  1:48   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452537674-20006-1-git-send-email-geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).