From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 20 May 2013 13:46:59 +0000 Subject: Re: [PATCH v2] pwm: renesas-tpu: Add missing pwmchip_remove() call in tpu_remove() Message-Id: <1454213.B1kNpQ6JtX@avalon> List-Id: References: <1369057541.11578.1.camel@phoenix> In-Reply-To: <1369057541.11578.1.camel@phoenix> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Axel Lin , Simon Horman Cc: Thierry Reding , linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Hi Axel, Thank you for the patch. On Monday 20 May 2013 21:45:41 Axel Lin wrote: > Signed-off-by: Axel Lin Acked-by: Laurent Pinchart > --- > drivers/pwm/pwm-renesas-tpu.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c > index 8e6d8d7..319a6fe 100644 > --- a/drivers/pwm/pwm-renesas-tpu.c > +++ b/drivers/pwm/pwm-renesas-tpu.c > @@ -432,6 +432,11 @@ static int tpu_remove(struct platform_device *pdev) > { > struct tpu_device *tpu = platform_get_drvdata(pdev); > unsigned int i; > + int ret; > + > + ret = pwmchip_remove(&tpu->chip); > + if (ret) > + return ret; > > for (i = 0; i < ARRAY_SIZE(tpu->pwms); ++i) { > struct tpu_pwm_device *pwm = &tpu->pwms[i]; -- Regards, Laurent Pinchart