* Re: [PATCH v7] rtc: rewrite DS1302 using SPI [not found] ` <1456224900-4877-1-git-send-email-ynvich@gmail.com> @ 2016-03-15 0:18 ` Alexandre Belloni 2016-03-18 10:38 ` Sergei Ianovich 0 siblings, 1 reply; 2+ messages in thread From: Alexandre Belloni @ 2016-03-15 0:18 UTC (permalink / raw) To: Sergei Ianovich, Yoshinori Sato, Rich Felker Cc: linux-kernel, Rob Herring, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Alessandro Zummo, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list:REAL TIME CLOCK RTC SUBSYSTEM, linux-sh Hi, Thank you for your work! On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote : > -#ifdef CONFIG_SH_SECUREEDGE5410 > -#include <asm/rtc.h> > -#include <mach/secureedge5410.h> > - > -#define RTC_RESET 0x1000 > -#define RTC_IODATA 0x0800 > -#define RTC_SCLK 0x0400 > - > -#define set_dp(x) SECUREEDGE_WRITE_IOPORT(x, 0x1c00) > -#define get_dp() SECUREEDGE_READ_IOPORT() > -#define ds1302_set_tx() > -#define ds1302_set_rx() > - I would like to have a solution for secureedge5410 even if it is untested. Else, we are breaking an existing platform without any solution. I've put the sh maintainers in copy, maybe they have an opinion. Else I'll let your patch sit in linux-next for the next cycle. I have further cleanups in that driver but they can probably be done later. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v7] rtc: rewrite DS1302 using SPI 2016-03-15 0:18 ` [PATCH v7] rtc: rewrite DS1302 using SPI Alexandre Belloni @ 2016-03-18 10:38 ` Sergei Ianovich 0 siblings, 0 replies; 2+ messages in thread From: Sergei Ianovich @ 2016-03-18 10:38 UTC (permalink / raw) To: Alexandre Belloni, Yoshinori Sato, Rich Felker Cc: linux-kernel, Rob Herring, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Alessandro Zummo, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list:REAL TIME CLOCK RTC SUBSYSTEM, linux-sh On Tue, 2016-03-15 at 01:18 +0100, Alexandre Belloni wrote: > I would like to have a solution for secureedge5410 even if it is > untested. Else, we are breaking an existing platform without any > solution. > > I've put the sh maintainers in copy, maybe they have an opinion. Else > I'll let your patch sit in linux-next for the next cycle. secureedge5410 will need an SPI host driver. The driver will be similar to the one I did for lp8841. I can make a clone for secureedge5410, but I cannot test it. The only reason, I didn't file the patch for secureedge5410, is I thought SPI people won't accept an untested patch. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-18 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1456105286-28598-1-git-send-email-ynvich@gmail.com>
[not found] ` <1456224900-4877-1-git-send-email-ynvich@gmail.com>
2016-03-15 0:18 ` [PATCH v7] rtc: rewrite DS1302 using SPI Alexandre Belloni
2016-03-18 10:38 ` Sergei Ianovich
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).