From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
linux-sh@vger.kernel.org, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: [PATCH 0/4] sh: fix up modular use in non-modular code
Date: Fri, 22 Apr 2016 18:07:00 +0000 [thread overview]
Message-ID: <1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com> (raw)
For anyone new to the underlying goal of this cleanup, we are trying to
make kernel code consistent with the Makefiles/Kconfigs that control them.
This means not using modular functions/macros for code that can never
be built as a module. Some of the other downfalls this leads to are:
(1) it is easy to accidentally write unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else, thus adding to CPP overhead.
(4) it gets copied/replicated into other drivers and spreads like weeds.
Three of the four commits here are completely trivial with zero runtime
impact whatsoever. The fourth has a deletion of a ".remove" function
and as we've done elsewhere, we block the sysfs ability to reach in and
manually execute that function, since there isn't a sane use case for
which doing that makes sense.
Build tested on today's linux-next ; full build fails on duplicate syms
from OF generic board, but that is a known and reported issue elsewhere;
it has nothing to do with the changes here.
Paul
--
Cc: linux-sh@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Rich Felker <dalias@libc.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Paul Gortmaker (4):
sh: make time.c explicitly non-modular
sh: make mm/asids-debugfs explicitly non-modular
sh: make board-secureedge5410 explicitly non-modular
sh: make heartbeat driver explicitly non-modular
arch/sh/boards/board-secureedge5410.c | 3 +--
arch/sh/drivers/heartbeat.c | 32 +++-----------------------------
arch/sh/kernel/time.c | 3 +--
arch/sh/mm/asids-debugfs.c | 5 +----
4 files changed, 6 insertions(+), 37 deletions(-)
--
2.8.0
next reply other threads:[~2016-04-22 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 18:07 Paul Gortmaker [this message]
2016-04-22 18:07 ` [PATCH 1/4] sh: make time.c explicitly non-modular Paul Gortmaker
2016-04-22 18:07 ` [PATCH 2/4] sh: make mm/asids-debugfs " Paul Gortmaker
2016-04-22 18:07 ` [PATCH 3/4] sh: make board-secureedge5410 " Paul Gortmaker
2016-04-22 18:07 ` [PATCH 4/4] sh: make heartbeat driver " Paul Gortmaker
2016-05-26 16:45 ` [PATCH 0/4] sh: fix up modular use in non-modular code Paul Gortmaker
2016-05-26 16:53 ` Rich Felker
2016-06-02 6:54 ` Yoshinori Sato
2016-07-02 23:40 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461348424-3896-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).