From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 1/3] DMA: shdma: Fix warnings due to improper casts and printk formats
Date: Wed, 11 Dec 2013 14:27:41 +0000 [thread overview]
Message-ID: <1467807.P36IqR6kbP@avalon> (raw)
In-Reply-To: <1386765786-1926-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wednesday 11 December 2013 12:59:34 Shevchenko, Andriy wrote:
> On Wed, 2013-12-11 at 13:43 +0100, Laurent Pinchart wrote:
>
> > Use the %zu and %pad printk specifiers to print size_t and dma_addr_t
> > variables, and cast pointers to uintptr_t instead of unsigned int where
> > applicable. This fixes warnings on platforms where pointers and/or
> > dma_addr_t have a different size than int
>
> Thanks for an updated version. Now looks better with those %pad.
> One comment below.
>
> > @@ -555,7 +555,7 @@ static struct dma_async_tx_descriptor
> > *shdma_prep_sg(struct shdma_chan *schan,
> > goto err_get_desc;
> >
> > do {
> > - dev_dbg(schan->dev, "Add SG #%d@%p[%d], dma %llx\n",
> > + dev_dbg(schan->dev, "Add SG #%d@%p[%zu], dma %llx\n",
> > i, sg, len, (unsigned long long)sg_addr);
>
> sg_addr -> %pad as well ?
Indeed. I'll repost this patch.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-11 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 12:43 [PATCH v3 1/3] DMA: shdma: Fix warnings due to improper casts and printk formats Laurent Pinchart
2013-12-11 12:59 ` Shevchenko, Andriy
2013-12-11 14:27 ` Laurent Pinchart [this message]
2014-01-07 15:08 ` Laurent Pinchart
2014-01-21 12:10 ` Laurent Pinchart
2014-03-04 11:42 ` Laurent Pinchart
2014-03-04 16:50 ` Koul, Vinod
2014-03-04 17:07 ` Laurent Pinchart
2014-03-06 6:20 ` Vinod Koul
2014-03-06 11:24 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467807.P36IqR6kbP@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).