From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: hpa@zytor.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, linux@arm.linux.org.uk, mhiramat@kernel.org,
masami.hiramatsu.pt@hitachi.com, jbaron@akamai.com,
heiko.carstens@de.ibm.com, ananth@linux.vnet.ibm.com,
anil.s.keshavamurthy@intel.com, davem@davemloft.net,
realmz6@gmail.com
Cc: x86@kernel.org, luto@amacapital.net, keescook@chromium.org,
torvalds@linux-foundation.org, gregkh@linuxfoundation.org,
rusty@rustcorp.com.au, gnomes@lxorguk.ukuu.org.uk,
alan@linux.intel.com, dwmw2@infradead.org, arnd@arndb.de,
ming.lei@canonical.com, linux-arch@vger.kernel.org,
benh@kernel.crashing.org, ananth@in.ibm.com, pebolle@tiscali.nl,
fontana@sharpeleven.org, ciaran.farrell@suse.com,
christopher.denicolo@suse.com, david.vrabel@citrix.com,
konrad.wilk@oracle.com, mcb30@ipxe.org, jgross@suse.com,
andrew.cooper3@citrix.com, andriy.shevchenko@linux.intel.com,
paul.gortmaker@windriver.com, xen-devel@lists.xensource.com,
ak@linux.intel.com, pali.rohar@gmail.com, dvhart@infradead.org,
platform-driver-x86@vger.kernel.org, mmarek@suse.com,
linux@rasmusvillemoes.dk, jkosina@suse.cz, korea.drzix@gmail.com,
linux-kbuild@vger.kernel.org, tony.luck@intel.com,
akpm@linux-foun
Subject: [RFC v3 01/13] x86: remove LTO_REFERENCE_INITCALL()
Date: Fri, 22 Jul 2016 21:24:35 +0000 [thread overview]
Message-ID: <1469222687-1600-2-git-send-email-mcgrof@kernel.org> (raw)
In-Reply-To: <1469222687-1600-1-git-send-email-mcgrof@kernel.org>
The setup for LTO never made it upstream, and although this has
some users, this is now really old stuff for a gcc 4.7 LTO problem.
We know that at least LTO_REFERENCE_INITCALL() work around can
be removed if LTO is not supported on v4.7 anymore.
As per Andi the DISABLE_LTO and LTO_CFLAGS are still neeeded though.
v3: added to this series, removing LTO_REFERENCE_INITCALL()
justifies that other future similar macros do not need
a respective LTO_REFERENCE_INITCALL() on them therefore
simplifying new code.
Acked-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
---
include/linux/init.h | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/include/linux/init.h b/include/linux/init.h
index 1e5c131d5c9a..aa662ad80d9c 100644
--- a/include/linux/init.h
+++ b/include/linux/init.h
@@ -151,23 +151,6 @@ extern bool initcall_debug;
#ifndef __ASSEMBLY__
-#ifdef CONFIG_LTO
-/* Work around a LTO gcc problem: when there is no reference to a variable
- * in a module it will be moved to the end of the program. This causes
- * reordering of initcalls which the kernel does not like.
- * Add a dummy reference function to avoid this. The function is
- * deleted by the linker.
- */
-#define LTO_REFERENCE_INITCALL(x) \
- ; /* yes this is needed */ \
- static __used __exit void *reference_##x(void) \
- { \
- return &x; \
- }
-#else
-#define LTO_REFERENCE_INITCALL(x)
-#endif
-
/* initcalls are now grouped by functionality into separate
* subsections. Ordering inside the subsections is determined
* by link order.
@@ -180,8 +163,7 @@ extern bool initcall_debug;
#define __define_initcall(fn, id) \
static initcall_t __initcall_##fn##id __used \
- __attribute__((__section__(".initcall" #id ".init"))) = fn; \
- LTO_REFERENCE_INITCALL(__initcall_##fn##id)
+ __attribute__((__section__(".initcall" #id ".init"))) = fn;
/*
* Early initcalls run before initializing SMP.
--
2.8.4
next prev parent reply other threads:[~2016-07-22 21:24 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-22 21:24 [RFC v3 00/13] linux: generalize sections, ranges and linker tables Luis R. Rodriguez
2016-07-22 21:24 ` Luis R. Rodriguez [this message]
2016-07-22 21:24 ` [RFC v3 02/13] dell-smo8800: include uaccess.h Luis R. Rodriguez
2016-07-22 21:31 ` Pali Rohár
2016-07-22 21:24 ` [RFC v3 03/13] scripts/module-common.lds: enable generation Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 04/13] sections.h: guard against asm and linker script Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 05/13] sections.h: add sections header to collect all section info Luis R. Rodriguez
2016-07-22 21:37 ` James Hogan
2016-07-22 21:41 ` Luis R. Rodriguez
2016-07-29 17:28 ` Steven Rostedt
2016-07-22 21:24 ` [RFC v3 06/13] ranges.h: add helpers to build and identify Linux section ranges Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 07/13] tables.h: add linker table support Luis R. Rodriguez
2016-07-25 15:30 ` Masami Hiramatsu
2016-07-27 23:02 ` Luis R. Rodriguez
2016-07-28 17:08 ` H. Peter Anvin
2016-07-29 10:06 ` Borislav Petkov
2016-08-08 15:05 ` Luis R. Rodriguez
2016-08-09 3:55 ` Borislav Petkov
2016-08-12 3:51 ` Luis R. Rodriguez
2016-08-12 5:23 ` Borislav Petkov
2016-08-12 6:50 ` Luis R. Rodriguez
2016-08-12 7:25 ` Borislav Petkov
2016-08-12 15:28 ` Luis R. Rodriguez
2016-08-12 15:51 ` Borislav Petkov
2016-08-12 17:04 ` Luis R. Rodriguez
2016-08-12 17:35 ` Borislav Petkov
2016-08-12 20:23 ` Greg KH
2016-08-12 20:46 ` Jiri Kosina
2016-08-12 22:00 ` Luis R. Rodriguez
2016-08-13 10:46 ` Greg KH
2016-08-13 17:54 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 08/13] firmware/Makefile: force recompilation if makefile changes Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 09/13] firmware: port built-in section to linker table Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 10/13] jump_label: port __jump_table to linker tables Luis R. Rodriguez
2016-07-22 21:49 ` Josh Poimboeuf
2016-07-22 22:26 ` Luis R. Rodriguez
2016-07-22 22:55 ` Josh Poimboeuf
2016-07-27 22:55 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 11/13] dynamic_debug: port to use " Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 12/13] kprobes: port .kprobes.text to section range Luis R. Rodriguez
2016-07-25 15:19 ` Masami Hiramatsu
2016-07-27 22:40 ` Luis R. Rodriguez
2016-07-22 21:24 ` [RFC v3 13/13] kprobes: port blacklist kprobes to linker table Luis R. Rodriguez
2016-07-25 15:27 ` Masami Hiramatsu
2016-07-27 23:00 ` Luis R. Rodriguez
2016-07-25 13:32 ` [RFC v3 00/13] linux: generalize sections, ranges and linker tables Masami Hiramatsu
2016-07-25 13:55 ` Richard Fontana
2016-07-27 22:46 ` Luis R. Rodriguez
2016-08-09 14:24 ` One Thousand Gnomes
2016-08-09 16:09 ` James Bottomley
2016-08-10 17:03 ` Luis R. Rodriguez
[not found] ` <CALCETrVmDhPC6BMu4_xTanSFZBKeW9V6A4SeQ4qxnpVod-eLbQ@mail.gmail.com>
[not found] ` <1471292106.5944.3.camel@linux.intel.com>
2016-08-15 21:00 ` Steven Rostedt
2016-08-15 22:40 ` James Bottomley
2016-08-15 22:44 ` James Bottomley
2016-08-09 16:48 ` Richard Fontana
2016-08-09 16:52 ` Richard Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469222687-1600-2-git-send-email-mcgrof@kernel.org \
--to=mcgrof@kernel.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foun \
--cc=alan@linux.intel.com \
--cc=ananth@in.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=andrew.cooper3@citrix.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=christopher.denicolo@suse.com \
--cc=ciaran.farrell@suse.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=dvhart@infradead.org \
--cc=dwmw2@infradead.org \
--cc=fontana@sharpeleven.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jbaron@akamai.com \
--cc=jgross@suse.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=korea.drzix@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@rasmusvillemoes.dk \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mcb30@ipxe.org \
--cc=mhiramat@kernel.org \
--cc=ming.lei@canonical.com \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=pali.rohar@gmail.com \
--cc=paul.gortmaker@windriver.com \
--cc=pebolle@tiscali.nl \
--cc=platform-driver-x86@vger.kernel.org \
--cc=realmz6@gmail.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).