From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator
Date: Thu, 25 Apr 2013 12:34:32 +0000 [thread overview]
Message-ID: <1476930.bnntLHLWbT@avalon> (raw)
In-Reply-To: <1366840828-17335-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Simon,
Could you please apply those patches ? For your convenience I've added Mark's
ack to 2/4 and pushed the result to
git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0
On Thursday 25 April 2013 00:00:24 Laurent Pinchart wrote:
> Hello,
>
> The sh73a0 has an internal power gate on the VCCQ power supply for the SDHI0
> device that is controlled (for some strange reason) by a bit in a PFC
> register.
>
> This patch set exposes the power gate as a regulator. As the only currently
> supported board (kzm9g) has the VCCQ_MC0 pins directly connected to an
> always on 3.3V supply, the code assumes that the external VCCQ power supply
> can't be controlled. This could be fixed later by setting the regulator
> supply name.
>
> As this series turns the power off when not needed it might bring additional
> power saving, but this hasn't been measured. If the patches are considered
> too complex a simpler approach would be to turn the power gate on when the
> SDHI function is selected.
>
> The patches are based on tags/renesas-next-20130422. They have been tested
> on kzm9g. They are available in my git tree at
>
> git://linuxtv.org/pinchartl/fbdev.git pinmux/3.9/sh73a0
>
> Changes compared to v1:
>
> - Renamed __sh73a0_vccq_mc0_enable to sh73a0_vccq_mc0_endisable
> - Fix the reported voltage value (3.3V instead of 1.8V)
> - Make patch 2/4 commit message more explicit
>
> Laurent Pinchart (4):
> sh-pfc: Add support for SoC-specific initialization
> sh-pfc: sh73a0: Add VCCQ MC0 regulator
> ARM: shmobile: kzm9g: Remove the VCCQ MC0 function GPIO
> ARM: shmobile: kzm9g-reference: Remove the VCCQ MC0 function GPIO
>
> arch/arm/mach-shmobile/board-kzm9g-reference.c | 1 -
> arch/arm/mach-shmobile/board-kzm9g.c | 3 -
> drivers/pinctrl/sh-pfc/Kconfig | 1 +
> drivers/pinctrl/sh-pfc/core.c | 16 ++-
> drivers/pinctrl/sh-pfc/core.h | 1 +
> drivers/pinctrl/sh-pfc/pfc-sh73a0.c | 134 ++++++++++++++++++++++
> drivers/pinctrl/sh-pfc/sh_pfc.h | 2 +
> 7 files changed, 153 insertions(+), 5 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-25 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 22:00 [PATCH v2 0/4] sh73a0: Expose the PFC-controller SDHI power gate as a regulator Laurent Pinchart
2013-04-25 12:34 ` Laurent Pinchart [this message]
2013-04-25 13:03 ` Simon Horman
2013-04-26 2:04 ` Simon Horman
2013-04-26 3:57 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476930.bnntLHLWbT@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox