linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Mike Turquette <mturquette@linaro.org>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	devicetree@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/6] clk: shmobile: Deprecate renesas,clock-indices
Date: Thu, 30 Oct 2014 10:22:26 +0000	[thread overview]
Message-ID: <1477250.OEPthyD3Lv@avalon> (raw)
In-Reply-To: <1414592353-24044-2-git-send-email-geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Wednesday 29 October 2014 15:19:08 Geert Uytterhoeven wrote:
> Commit 8e33f91a0b84ae19 ("clk: shmobile: clk-mstp: change to using
> clock-indices") forgot to mark "renesas,clock-indices" deprecated in
> the driver-specific binding documentation.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  .../devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt        | 9 ++++--
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt index
> a5f52238c80d5f9b..26ab9fc499f51113 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> @@ -26,11 +26,12 @@ Required Properties:
>      must appear in the same order as the output clocks.
>    - #clock-cells: Must be 1
>    - clock-output-names: The name of the clocks as free-form strings
> -  - renesas,clock-indices: Indices of the gate clocks into the group (0 to
> 31)
> +  - clock-indices: Indices of the gate clocks into the group (0 to 31)
> +    ("renesas,clock-indices" is deprecated)

Nitpicking here, I would drop the reference to renesas,clock-indices 
completely.

Apart from that, for the whole series,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> -The clocks, clock-output-names and renesas,clock-indices properties contain
> one
> -entry per gate clock. The MSTP groups are sparsely populated. Unimplemented
> -gate clocks must not be declared.
> +The clocks, clock-output-names and clock-indices properties contain one
> entry
> +per gate clock. The MSTP groups are sparsely populated. Unimplemented gate
> +clocks must not be declared.
> 
> 
>  Example

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2014-10-30 10:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 14:19 [PATCH 0/6] ARM: shmobile: Change to using clock-indices Geert Uytterhoeven
2014-10-29 14:19 ` [PATCH 1/6] clk: shmobile: Deprecate renesas,clock-indices Geert Uytterhoeven
2014-10-30  1:06   ` Simon Horman
2014-10-30  1:46     ` Simon Horman
2014-10-30 10:22   ` Laurent Pinchart [this message]
2014-10-29 14:19 ` [PATCH 2/6] ARM: shmobile: r8a7740 dtsi: Change to using clock-indices Geert Uytterhoeven
2014-10-29 14:19 ` [PATCH 3/6] ARM: shmobile: r8a7779 " Geert Uytterhoeven
     [not found] ` <1414592353-24044-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2014-10-29 14:19   ` [PATCH 4/6] ARM: shmobile: r8a7790 " Geert Uytterhoeven
2014-10-29 14:19   ` [PATCH 6/6] ARM: shmobile: r8a7794 " Geert Uytterhoeven
2014-10-29 14:19 ` [PATCH 5/6] ARM: shmobile: r8a7791 " Geert Uytterhoeven
2014-10-30  0:10 ` [PATCH 0/6] ARM: shmobile: " Kuninori Morimoto
2014-10-30 20:40 ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477250.OEPthyD3Lv@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).