From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC 05/10] ARM: shmobile: r8a7790: add I2C setup
Date: Mon, 02 Sep 2013 13:24:27 +0000 [thread overview]
Message-ID: <1484300.FYhBxyDjcp@avalon> (raw)
Hello,
Thank you for the patch.
On Friday 30 August 2013 14:37:39 Ulrich Hecht wrote:
> From: Nguyen Viet Dung <nv-dung@jinso.co.jp>
>
> This patch add setup for I2C bus.
>
> Signed-off-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> ---
> arch/arm/mach-shmobile/include/mach/r8a7790.h | 3 +++
> arch/arm/mach-shmobile/setup-r8a7790.c | 28 ++++++++++++++++++++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7790.h
> b/arch/arm/mach-shmobile/include/mach/r8a7790.h index 177a837..ad8b502
> 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7790.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7790.h
> @@ -1,7 +1,10 @@
> #ifndef __ASM_R8A7790_H__
> #define __ASM_R8A7790_H__
>
> +#include <linux/i2c/i2c-rcar.h>
> +
> void r8a7790_add_standard_devices(void);
> +void r8a7790_add_i2c_device(int idx, struct i2c_rcar_platform_data *pdata);
> void r8a7790_add_dt_devices(void);
> void r8a7790_clock_init(void);
> void r8a7790_pinmux_init(void);
If I'm not mistaken (Magnus can probably confirm) this is discouraged.
Platform device setup should be added directly to the board files instead of
the setup-*.c files in order to avoid filling setup-*.c with legacy platform
devices.
> diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c
> b/arch/arm/mach-shmobile/setup-r8a7790.c index e0d29a2..969fdf2 100644
> --- a/arch/arm/mach-shmobile/setup-r8a7790.c
> +++ b/arch/arm/mach-shmobile/setup-r8a7790.c
> @@ -19,6 +19,7 @@
> */
>
> #include <linux/clocksource.h>
> +#include <linux/i2c/i2c-rcar.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/of_platform.h>
> @@ -196,6 +197,33 @@ void __init r8a7790_add_dt_devices(void)
> r8a7790_register_cmt(00);
> }
>
> +/* I2C */
> +static struct resource rcar_i2c_res[] __initdata = {
> + /* I2C0 */
> + DEFINE_RES_MEM(0xe6508000, 0x10000),
> + DEFINE_RES_IRQ(gic_spi(287)),
> + /* I2C1 */
> + DEFINE_RES_MEM(0xe6518000, 0x10000),
> + DEFINE_RES_IRQ(gic_spi(288)),
> + /* I2C2 */
> + DEFINE_RES_MEM(0xe6530000, 0x10000),
> + DEFINE_RES_IRQ(gic_spi(286)),
> + /* I2C3 */
> + DEFINE_RES_MEM(0xe6540000, 0x10000),
> + DEFINE_RES_IRQ(gic_spi(290)),
> +};
> +
> +void __init r8a7790_add_i2c_device(int idx,
> + struct i2c_rcar_platform_data *pdata)
> +{
> + BUG_ON(idx < 0 || idx > 3);
> +
> + platform_device_register_resndata(
> + &platform_bus, "i2c-rcar", idx,
> + rcar_i2c_res + (2*idx), 2,
> + pdata, sizeof(*pdata));
> +}
> +
> void __init r8a7790_add_standard_devices(void)
> {
> r8a7790_add_dt_devices();
--
Regards,
Laurent Pinchart
next reply other threads:[~2013-09-02 13:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 13:24 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-30 12:37 [RFC 05/10] ARM: shmobile: r8a7790: add I2C setup Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484300.FYhBxyDjcp@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox