From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC 10/10] ARM: shmobile: r8a7790: lager: HDMI output via DU and ADV7511
Date: Mon, 02 Sep 2013 13:41:55 +0000 [thread overview]
Message-ID: <1535400.aGgoBfJC9M@avalon> (raw)
In-Reply-To: <1377866264-21110-11-git-send-email-ulrich.hecht@gmail.com>
On Friday 30 August 2013 21:38:53 Sergei Shtylyov wrote:
> On 08/30/2013 04:37 PM, Ulrich Hecht wrote:
> > This builds and runs but is unlikely to provide useful output as I do not
> > have physical access to a Lager board yet.
> >
> > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> > ---
> >
> > arch/arm/mach-shmobile/board-lager.c | 24 ++++++++++++++++++++++++
> > 1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm/mach-shmobile/board-lager.c
> > b/arch/arm/mach-shmobile/board-lager.c index c6b5f21..edd0f3e 100644
> > --- a/arch/arm/mach-shmobile/board-lager.c
> > +++ b/arch/arm/mach-shmobile/board-lager.c
> > @@ -40,12 +40,20 @@
> >
> > #include <asm/mach-types.h>
> > #include <asm/mach/arch.h>
> >
> > +#include "../../../drivers/gpu/drm/i2c/adv7511.h"
>
> Shouldn't this header moved into include/linux/platform_data/ first?
Agreed. The header should even be split into platform data (to be moved to
include/linux/platform_data/adv7511.h) and driver-private data that can be
kept in drivers/gpu/drm/i2c/adv7511.h (or possibly be moved to
drivers/gpu/drm/i2c/adv7511.c, I have no strong preference there).
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2013-09-02 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 12:37 [RFC 10/10] ARM: shmobile: r8a7790: lager: HDMI output via DU and ADV7511 Ulrich Hecht
2013-08-30 17:38 ` Sergei Shtylyov
2013-09-02 13:41 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1535400.aGgoBfJC9M@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).