* [PATCH] sh: mm: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
@ 2018-09-10 2:55 zhong jiang
2018-09-10 10:02 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-09-10 2:55 UTC (permalink / raw)
To: dalias, ysato
Cc: robin.murphy, thomas.petazzoni, geert+renesas, linux-sh,
linux-kernel
dma_zalloc_coherent has taken the dma_alloc_coherent() and memset() into
account. Therefore, just use dma_zalloc_coherent to replace the open code.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
arch/sh/mm/consistent.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/sh/mm/consistent.c b/arch/sh/mm/consistent.c
index 792f361..aa4e450 100644
--- a/arch/sh/mm/consistent.c
+++ b/arch/sh/mm/consistent.c
@@ -52,14 +52,12 @@ int __init platform_resource_setup_memory(struct platform_device *pdev,
if (!memsize)
return 0;
- buf = dma_alloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
+ buf = dma_zalloc_coherent(&pdev->dev, memsize, &dma_handle, GFP_KERNEL);
if (!buf) {
pr_warning("%s: unable to allocate memory\n", name);
return -ENOMEM;
}
- memset(buf, 0, memsize);
-
r->flags = IORESOURCE_MEM;
r->start = dma_handle;
r->end = r->start + memsize - 1;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] sh: mm: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset
2018-09-10 2:55 [PATCH] sh: mm: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset zhong jiang
@ 2018-09-10 10:02 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2018-09-10 10:02 UTC (permalink / raw)
To: zhongjiang
Cc: Rich Felker, Yoshinori Sato, Robin Murphy, Thomas Petazzoni,
Geert Uytterhoeven, Linux-sh list, Linux Kernel Mailing List
On Mon, Sep 10, 2018 at 5:07 AM zhong jiang <zhongjiang@huawei.com> wrote:
> dma_zalloc_coherent has taken the dma_alloc_coherent() and memset() into
> account. Therefore, just use dma_zalloc_coherent to replace the open code.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-10 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-10 2:55 [PATCH] sh: mm: Use dma_zalloc_coherent instead of dma_alloc_coherent + memset zhong jiang
2018-09-10 10:02 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).