Re: [PATCH 19/21] treewide: add checks for the return value of memblock_alloc*()

Guo Ren
2019-01-17T07:06:03Z

On Wed, Jan 16, 2019 at 03:44:19PM +0200, Mike Rapoport wrote:
> arch/csky/mm/highmem.c | 5 +++++
...
> diff --git a/arch/csky/mm/highmem.c b/arch/csky/mm/highmem.c
> index 53b1bfa..3317b774 100644
> --- a/arch/csky/mm/highmem.c
> +++ b/arch/csky/mm/highmem.c
> @@ -141,6 +141,11 @@ static void __init fixrange_init(unsigned long start, unsigned long end,
> for (; (k < PTRS_PER_PMD) && (vaddr != end); pmd++, k++) {
> if (pmd_none(*pmd)) {
> pte = (pte_t *) memblock_alloc_low(PAGE_SIZE, PAGE_SIZE);
> + if (!pte)
> + panic("%s: Failed to allocate %lu bytes align=%lx\n",
> + __func__, PAGE_SIZE,
> + PAGE_SIZE);
> +
> set_pmd(pmd, __pmd(__pa(pte)));
> BUG_ON(pte != pte_offset_kernel(pmd, 0));
> }

Looks good for me and panic is ok.

Reviewed-by: Guo Ren <ren_guo@c-sky.com>