* [PATCH v2 07/10] ARM: shmobile: kzm9g: require ZB1 clock for Ethernet controller
@ 2014-09-02 9:13 Ulrich Hecht
2014-09-09 22:03 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Ulrich Hecht @ 2014-09-02 9:13 UTC (permalink / raw)
To: linux-sh
Unlike the legacy stuff, CCF disables the ethernet controller's clock
unless it is used somewhere.
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
index 83c6058..a7e1c46 100644
--- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
+++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
@@ -90,6 +90,7 @@
interrupt-parent = <&irqpin0>;
interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
reg-io-width = <4>;
+ clocks = <&zb1_clk>;
smsc,irq-push-pull;
smsc,save-mac-address;
vddvario-supply = <®_1p8v>;
--
1.8.4.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 07/10] ARM: shmobile: kzm9g: require ZB1 clock for Ethernet controller
2014-09-02 9:13 [PATCH v2 07/10] ARM: shmobile: kzm9g: require ZB1 clock for Ethernet controller Ulrich Hecht
@ 2014-09-09 22:03 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-09-09 22:03 UTC (permalink / raw)
To: linux-sh
Hi Ulrich,
Thank you for the patch.
On Tuesday 02 September 2014 11:13:03 Ulrich Hecht wrote:
> Unlike the legacy stuff, CCF disables the ethernet controller's clock
> unless it is used somewhere.
But the ethernet controller is not clocked by the ZB1 clock.
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> ---
> arch/arm/boot/dts/sh73a0-kzm9g-reference.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts index 83c6058..a7e1c46
> 100644
> --- a/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> +++ b/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
> @@ -90,6 +90,7 @@
> interrupt-parent = <&irqpin0>;
> interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
> reg-io-width = <4>;
> + clocks = <&zb1_clk>;
By the way, that clock is only named zb1 in a single location in the
datasheet, and just zb everywhere else. I think it should be renamed in patch
02/10.
> smsc,irq-push-pull;
> smsc,save-mac-address;
> vddvario-supply = <®_1p8v>;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-09 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-02 9:13 [PATCH v2 07/10] ARM: shmobile: kzm9g: require ZB1 clock for Ethernet controller Ulrich Hecht
2014-09-09 22:03 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).