* [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree
@ 2013-01-04 0:40 Laurent Pinchart
2013-01-04 16:10 ` Guennadi Liakhovetski
2013-01-07 22:27 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-01-04 0:40 UTC (permalink / raw)
To: linux-sh
Add a pfc node in the r8a7740 device tree.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/boot/dts/r8a7740.dtsi | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
index 798fa35..9586d66 100644
--- a/arch/arm/boot/dts/r8a7740.dtsi
+++ b/arch/arm/boot/dts/r8a7740.dtsi
@@ -18,4 +18,10 @@
compatible = "arm,cortex-a9";
};
};
+
+ gpio: pfc@e6050000 {
+ compatible = "renesas,pfc-r8a7740";
+ reg = <0xe6050000 0x8000>,
+ <0xe605800c 0x20>;
+ };
};
--
1.7.8.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree
2013-01-04 0:40 [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree Laurent Pinchart
@ 2013-01-04 16:10 ` Guennadi Liakhovetski
2013-01-07 22:27 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Guennadi Liakhovetski @ 2013-01-04 16:10 UTC (permalink / raw)
To: linux-sh
Hi Laurent
Thanks for patches!
On Fri, 4 Jan 2013, Laurent Pinchart wrote:
> Add a pfc node in the r8a7740 device tree.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm/boot/dts/r8a7740.dtsi | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi
> index 798fa35..9586d66 100644
> --- a/arch/arm/boot/dts/r8a7740.dtsi
> +++ b/arch/arm/boot/dts/r8a7740.dtsi
> @@ -18,4 +18,10 @@
> compatible = "arm,cortex-a9";
> };
> };
> +
> + gpio: pfc@e6050000 {
> + compatible = "renesas,pfc-r8a7740";
> + reg = <0xe6050000 0x8000>,
> + <0xe605800c 0x20>;
isn't
+ #gpio-cells = <2>;
missing here?
> + };
> };
> --
> 1.7.8.6
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree
2013-01-04 0:40 [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree Laurent Pinchart
2013-01-04 16:10 ` Guennadi Liakhovetski
@ 2013-01-07 22:27 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-01-07 22:27 UTC (permalink / raw)
To: linux-sh
Hi Guennadi,
On Friday 04 January 2013 17:10:05 Guennadi Liakhovetski wrote:
> Hi Laurent
>
> Thanks for patches!
>
> On Fri, 4 Jan 2013, Laurent Pinchart wrote:
> > Add a pfc node in the r8a7740 device tree.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7740.dtsi | 6 ++++++
> > 1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7740.dtsi
> > b/arch/arm/boot/dts/r8a7740.dtsi index 798fa35..9586d66 100644
> > --- a/arch/arm/boot/dts/r8a7740.dtsi
> > +++ b/arch/arm/boot/dts/r8a7740.dtsi
> > @@ -18,4 +18,10 @@
> > compatible = "arm,cortex-a9";
> > };
> > };
> > +
> > + gpio: pfc@e6050000 {
> > + compatible = "renesas,pfc-r8a7740";
> > + reg = <0xe6050000 0x8000>,
> > + <0xe605800c 0x20>;
>
> isn't
>
> + #gpio-cells = <2>;
>
> missing here?
Oops, indeed. And gpio-controller; as well. I'll add both. Thanks for the
report.
> > + };
> >
> > };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-07 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-04 0:40 [PATCH 3/9] ARM: shmobile: r8a7740: Add pin control device in device tree Laurent Pinchart
2013-01-04 16:10 ` Guennadi Liakhovetski
2013-01-07 22:27 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).