SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: r8a7791: fix CAN pin groups
Date: Mon, 28 Jul 2014 22:18:16 +0000	[thread overview]
Message-ID: <1626639.i7sCJokkLX@avalon> (raw)
In-Reply-To: <201407290212.55656.sergei.shtylyov@cogentembedded.com>

Hi Sergei,

Thank you for the patch.

On Tuesday 29 July 2014 02:12:55 Sergei Shtylyov wrote:
> I had made last-minute changes before submitting the patch "sh-pfc: r8a7791:
> add CAN pin groups"; now I'm seeing that they weren't complete: I had
> missed update to the pin group names in pin[01]_groups[]. Drop the "_a"
> suffixes there.
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git'
> repo.
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7791.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
> @@ -4509,24 +4509,24 @@ static const char * const audio_clk_grou
>  };
> 
>  static const char * const can0_groups[] = {
> -	"can0_data_a",
> +	"can0_data",
>  	"can0_data_b",
>  	"can0_data_c",
>  	"can0_data_d",
>  	"can0_data_e",
>  	"can0_data_f",
> -	"can_clk_a",
> +	"can_clk",
>  	"can_clk_b",
>  	"can_clk_c",
>  	"can_clk_d",
>  };
> 
>  static const char * const can1_groups[] = {
> -	"can1_data_a",
> +	"can1_data",
>  	"can1_data_b",
>  	"can1_data_c",
>  	"can1_data_d",
> -	"can_clk_a",
> +	"can_clk",
>  	"can_clk_b",
>  	"can_clk_c",
>  	"can_clk_d",

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2014-07-28 22:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-28 22:12 [PATCH] sh-pfc: r8a7791: fix CAN pin groups Sergei Shtylyov
2014-07-28 22:18 ` Laurent Pinchart [this message]
2014-08-08 12:58 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1626639.i7sCJokkLX@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox