* [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
@ 2014-04-08 0:21 Simon Horman
2014-04-08 12:07 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2014-04-08 0:21 UTC (permalink / raw)
To: linux-arm-kernel
The correct binding is "micrel,led-mode", not "led-mode".
This corrects an error which was introduced when setting of ethernet PHY
LED mode was added by 82e62182d59bd1d0 ("ARM: shmobile: lager: Set ethernet
PHY LED mode").
This makes the lager code consistent with the koelsch code which was added
by ae00d12a032490b3 ("ARM: shmobile: koelsch: Set ethernet PHY LED mode").
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
* This is compile tested only (which is of negligible value)
as I do not have physical access to a Lager board.
---
arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index a55c5f8..265cba1 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -213,7 +213,7 @@
reg = <1>;
interrupt-parent = <&irqc0>;
interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
- led-mode = <1>;
+ micrel,led-mode = <1>;
};
};
--
1.8.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
2014-04-08 0:21 [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode Simon Horman
@ 2014-04-08 12:07 ` Laurent Pinchart
2014-04-09 6:15 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-04-08 12:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Tuesday 08 April 2014 09:21:35 Simon Horman wrote:
> The correct binding is "micrel,led-mode", not "led-mode".
>
> This corrects an error which was introduced when setting of ethernet PHY
> LED mode was added by 82e62182d59bd1d0 ("ARM: shmobile: lager: Set ethernet
> PHY LED mode").
Indeed. I wonder how I've missed that... :-( Sorry.
> This makes the lager code consistent with the koelsch code which was added
> by ae00d12a032490b3 ("ARM: shmobile: koelsch: Set ethernet PHY LED mode").
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> * This is compile tested only (which is of negligible value)
> as I do not have physical access to a Lager board.
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index a55c5f8..265cba1 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -213,7 +213,7 @@
> reg = <1>;
> interrupt-parent = <&irqc0>;
> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> - led-mode = <1>;
> + micrel,led-mode = <1>;
> };
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
2014-04-08 12:07 ` Laurent Pinchart
@ 2014-04-09 6:15 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2014-04-09 6:15 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 08, 2014 at 02:07:49PM +0200, Laurent Pinchart wrote:
> Hi Simon,
>
> On Tuesday 08 April 2014 09:21:35 Simon Horman wrote:
> > The correct binding is "micrel,led-mode", not "led-mode".
> >
> > This corrects an error which was introduced when setting of ethernet PHY
> > LED mode was added by 82e62182d59bd1d0 ("ARM: shmobile: lager: Set ethernet
> > PHY LED mode").
>
> Indeed. I wonder how I've missed that... :-( Sorry.
Thanks, I have queued this up.
>
> > This makes the lager code consistent with the koelsch code which was added
> > by ae00d12a032490b3 ("ARM: shmobile: koelsch: Set ethernet PHY LED mode").
> >
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> >
> > * This is compile tested only (which is of negligible value)
> > as I do not have physical access to a Lager board.
> > ---
> > arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > b/arch/arm/boot/dts/r8a7790-lager.dts index a55c5f8..265cba1 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -213,7 +213,7 @@
> > reg = <1>;
> > interrupt-parent = <&irqc0>;
> > interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> > - led-mode = <1>;
> > + micrel,led-mode = <1>;
> > };
> > };
>
> --
> Regards,
>
> Laurent Pinchart
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-09 6:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-08 0:21 [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode Simon Horman
2014-04-08 12:07 ` Laurent Pinchart
2014-04-09 6:15 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).