From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC/PATCH 6/6] ARM: shmobile: koelsch: Enable SCIF0 and SCIF1 serial ports in DT
Date: Wed, 30 Apr 2014 06:18:29 +0000 [thread overview]
Message-ID: <1667554.lgOS1qWJLo@avalon> (raw)
In-Reply-To: <1398817906-6023-7-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Magnus,
On Wednesday 30 April 2014 04:55:22 Magnus Damm wrote:
> On Wed, Apr 30, 2014 at 12:31 AM, Laurent Pinchart wrote:
> > SCIF0 and SCIF1 are used as debug serial ports. Enable them and
> > configure pinmuxing appropriately. We can now remove the clkdev
> > registration hack for SCIF devices from the Koelsch reference board
> > file.
> >
> > As a side effect of switching to DT-based serial port instantiation,
> > ttySC6 and ttySC7 get renamed to ttySC0 and ttySC1. As the device tree
> > source if now shared between koelsch and koelsch-reference, we need to
> > update the serial ports in C code as well.
>
> Hi Laurent,
>
> Thanks for your efforts. I'm a bit confused, because I thought we
> agreed on keeping the serial order intact earlier?
>
> With that in mind, shouldn't aliases be updated in this patch to avoid
> rename of ttySC6 and 7?
The commit message is definitely wrong, and for some reason the aliases are
missing from the patch. Sorry about that. I'll resubmit.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-04-30 6:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 0:31 [RFC/PATCH 6/6] ARM: shmobile: koelsch: Enable SCIF0 and SCIF1 serial ports in DT Laurent Pinchart
2014-04-30 4:55 ` Magnus Damm
2014-04-30 6:18 ` Laurent Pinchart [this message]
2014-04-30 6:24 ` Simon Horman
2014-04-30 16:28 ` Laurent Pinchart
2014-05-14 5:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1667554.lgOS1qWJLo@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).