Re: [PATCH v3] iommu: shmobile: Enable the driver on all ARM platforms

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Wednesday 30 October 2013 09:28:54 Mark Brown wrote:
> On Wed, Oct 30, 2013 at 12:40:12PM +0100, Laurent Pinchart wrote:
> > > For similar reasons as x86, can we please think about using:
> > > 	depends on ARM
> > > 	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST
> > 
> > I'm fine with your proposed option. As I don't want to respin the series
> > dozens of time let's first agree on the course of action, I will then
> > repost the patches. Mark, you've pushed towards as few platform
> > dependencies as possible, what's your opinion on this ?
> 
> In general I think we should have whatever the real depedencies are or
> COMPILE_TEST (to the extent that they will actually build cleanly on
> other targets).  That way only people who explicitly go looking to
> compile test things for build coverage (eg, when doing global cleanups
> or API updates) need to be bothered by the extra compile test options.
> 
> I'd read the above as saying the code needs ARM to build at all and that
> the hardware will only ever appear on SHMOBILE.

That's my reading as well, and it makes sense to express it that way to me. 
I'll resubmit the whole series (minus the patches that have been applied 
already, I'll fix those in follow-up patches) with the dependencies expressed 
that way.

-- 
Regards,

Laurent Pinchart

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]