From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: bockw: fixup DMA mask
Date: Mon, 16 Dec 2013 18:16:06 +0000 [thread overview]
Message-ID: <173404064.5z31QBSyng@avalon> (raw)
In-Reply-To: <87vbypyzv3.wl%kuninori.morimoto.gx@gmail.com>
Hi Morimoto-san,
On Monday 16 December 2013 00:16:52 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> 4dcfa60071b3d23f0181f27d8519f12e37cefbb9
> (ARM: DMA-API: better handing of DMA masks for coherent allocations)
> exchanged DMA mask check method.
> Below warning will appear without this patch
>
> asoc-simple-card asoc-simple-card.0: \
> Coherent DMA mask 0xffffffffffffffff is larger than dma_addr_t allows
> asoc-simple-card asoc-simple-card.0: \
> Driver did not use or check the return value from dma_set_coherent_mask()?
I was investigating the same problem with LCDC on Armadillo when I've read
your patch, so thank you :-)
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/board-bockw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-bockw.c
> b/arch/arm/mach-shmobile/board-bockw.c index fd9ab9f..24b4161 100644
> --- a/arch/arm/mach-shmobile/board-bockw.c
> +++ b/arch/arm/mach-shmobile/board-bockw.c
> @@ -693,7 +693,7 @@ static void __init bockw_init(void)
> .id = i,
> .data = &rsnd_card_info[i],
> .size_data = sizeof(struct asoc_simple_card_info),
> - .dma_mask = ~0,
> + .dma_mask = DMA_BIT_MASK(32),
> };
>
> platform_device_register_full(&cardinfo);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-12-16 18:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:16 [PATCH] ARM: shmobile: bockw: fixup DMA mask Kuninori Morimoto
2013-12-16 18:16 ` Laurent Pinchart [this message]
2013-12-19 9:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173404064.5z31QBSyng@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox