From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support
Date: Mon, 02 Sep 2013 14:18:41 +0000 [thread overview]
Message-ID: <1738124.5rApJWhXUN@avalon> (raw)
In-Reply-To: <87ehb8th3c.wl%kuninori.morimoto.gx@renesas.com>
On Monday 02 September 2013 18:05:10 Sergei Shtylyov wrote:
> On 09/02/2013 05:14 PM, Laurent Pinchart wrote:
> >> Define the generic R8A777x part of the Ether device node.
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>
> >> ---
> >>
> >> arch/arm/boot/dts/r8a7778.dtsi | 11 +++++++++++
> >> 1 file changed, 11 insertions(+)
> >>
> >> Index: renesas/arch/arm/boot/dts/r8a7778.dtsi
> >> =================================> >> --- renesas.orig/arch/arm/boot/dts/r8a7778.dtsi
> >> +++ renesas/arch/arm/boot/dts/r8a7778.dtsi
> >> @@ -98,4 +98,15 @@
> >>
> >> reg = <0xfffc000 0x118>;
> >> #gpio-range-cells = <3>;
> >>
> >> };
> >>
> >> +
> >> + ether: ethernet@fde00000 {
> >> + device_type = "network";
> >
> > Documentation/devicetree/bindings/net/sh_eth.txt from "[PATCH 2/2] sh_eth:
> > add device tree support" doesn't document this property, should you
> > update it ?
> It's a standard property but completely optional for non-OF systems.
> I've not seen anybody document it but I should grep for it...
Documentation/devicetree/booting-without-of.txt mentions it, as well as a
couple of other DT bindings document, but there's no clear documentation of
what device_type should be for network device, and whether the property is
mandatory or optional. Clarifying the documentation would be great.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-09-02 14:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 5:52 [PATCH 1/4] ARM: shmobile: r8a7778: add usb phy power control function Kuninori Morimoto
2013-07-09 11:52 ` Sergei Shtylyov
2013-07-10 1:07 ` Simon Horman
2013-07-10 1:11 ` Kuninori Morimoto
2013-07-10 1:27 ` Kuninori Morimoto
2013-08-31 23:15 ` [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-02 13:14 ` Laurent Pinchart
2013-09-02 14:05 ` Sergei Shtylyov
2013-09-02 14:18 ` Laurent Pinchart [this message]
2013-09-02 15:32 ` Pawel Moll
2013-09-03 12:11 ` Laurent Pinchart
2013-09-03 13:53 ` Sergei Shtylyov
2013-09-03 15:17 ` Magnus Damm
2013-09-03 18:27 ` Sergei Shtylyov
2013-09-04 5:35 ` Magnus Damm
2013-09-04 9:39 ` Laurent Pinchart
2013-09-05 6:03 ` Simon Horman
2013-10-04 6:43 ` [PATCH 1/4] ARM: shmobile: r8a7778: add I2C clock for DT Kuninori Morimoto
2013-10-08 1:49 ` Simon Horman
2014-01-14 2:25 ` [PATCH 1/4] ARM: shmobile: r8a7778: add audio clock in new style Kuninori Morimoto
2014-07-15 9:16 ` [PATCH 1/4] ARM: shmobile: r8a7778: add SCI clock support for DT Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1738124.5rApJWhXUN@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).