From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: iommu@lists.linux-foundation.org,
laurent.pinchart+renesas@ideasonboard.com,
geert+renesas@glider.be, linux-sh@vger.kernel.org,
joro@8bytes.org, linux-kernel@vger.kernel.org,
horms+renesas@verge.net.au
Subject: Re: [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency
Date: Mon, 19 Oct 2015 06:42:14 +0000 [thread overview]
Message-ID: <1739171.POGWkgX12k@avalon> (raw)
In-Reply-To: <20151019030253.6274.46547.sendpatchset@little-apple>
Hi Magnus,
Thank you for the patch.
On Monday 19 October 2015 12:02:53 Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> Neither the ARM page table code enabled by IOMMU_IO_PGTABLE_LPAE
> nor the IPMMU_VMSA driver actually depends on ARM_LPAE, so get
> rid of the dependency.
>
> Tested with ipmmu-vmsa on r8a7794 ALT and a kernel config using:
> # CONFIG_ARM_LPAE is not set
The driver only supports the 40-bits page table format for now, hence the
dependency on LPAE, but it indeed seems that the dependency is bogus. As long
as the 8 MSBs of the translated address are all 0 I assume the output 40-bit
address is usable on a 32-bit physical address system.
How have you tested the patch ?
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> drivers/iommu/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> --- 0001/drivers/iommu/Kconfig
> +++ work/drivers/iommu/Kconfig 2015-10-18 14:58:09.080513000 +0900
> @@ -324,7 +324,6 @@ config SHMOBILE_IOMMU_L1SIZE
>
> config IPMMU_VMSA
> bool "Renesas VMSA-compatible IPMMU"
> - depends on ARM_LPAE
> depends on ARCH_SHMOBILE || COMPILE_TEST
> select IOMMU_API
> select IOMMU_IO_PGTABLE_LPAE
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-10-19 6:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 3:02 [PATCH] iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency Magnus Damm
2015-10-19 6:42 ` Laurent Pinchart [this message]
2015-10-20 8:54 ` Magnus Damm
2015-10-20 10:28 ` Laurent Pinchart
2015-10-23 9:49 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1739171.POGWkgX12k@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=horms+renesas@verge.net.au \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).