linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Fenghua Yu <fenghua.yu@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mundt <lethal@linux-sh.org>,
	Paul Mackerras <paulus@samba.org>,
	Yinghai Lu <yinghai@kernel.org>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 1/2] PCI: hotplug: Convert to be builtin only, not modular
Date: Thu, 25 Jul 2013 19:34:26 +0000	[thread overview]
Message-ID: <1790250.TtZ9d6PaXM@vostro.rjw.lan> (raw)
In-Reply-To: <20130725175720.6006.96448.stgit@bhelgaas-glaptop>

On Thursday, July 25, 2013 11:57:20 AM Bjorn Helgaas wrote:
> Convert CONFIG_HOTPLUG_PCI from tristate to bool.  This only affects
> the hotplug core; several of the hotplug drivers can still be modules.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  arch/ia64/configs/generic_defconfig    |    2 +-
>  arch/ia64/configs/gensparse_defconfig  |    2 +-
>  arch/ia64/configs/tiger_defconfig      |    2 +-
>  arch/ia64/configs/xen_domu_defconfig   |    2 +-
>  arch/powerpc/configs/ppc64_defconfig   |    2 +-
>  arch/powerpc/configs/ppc64e_defconfig  |    2 +-
>  arch/powerpc/configs/pseries_defconfig |    2 +-
>  arch/sh/configs/sh03_defconfig         |    2 +-
>  drivers/pci/hotplug/Kconfig            |    5 +----
>  9 files changed, 9 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/ia64/configs/generic_defconfig b/arch/ia64/configs/generic_defconfig
> index 7913695..efbd292 100644
> --- a/arch/ia64/configs/generic_defconfig
> +++ b/arch/ia64/configs/generic_defconfig
> @@ -31,7 +31,7 @@ CONFIG_ACPI_FAN=m
>  CONFIG_ACPI_DOCK=y
>  CONFIG_ACPI_PROCESSOR=m
>  CONFIG_ACPI_CONTAINER=m
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_ACPI=m
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> diff --git a/arch/ia64/configs/gensparse_defconfig b/arch/ia64/configs/gensparse_defconfig
> index f8e9133..f64980d 100644
> --- a/arch/ia64/configs/gensparse_defconfig
> +++ b/arch/ia64/configs/gensparse_defconfig
> @@ -25,7 +25,7 @@ CONFIG_ACPI_BUTTON=m
>  CONFIG_ACPI_FAN=m
>  CONFIG_ACPI_PROCESSOR=m
>  CONFIG_ACPI_CONTAINER=m
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_ACPI=m
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> diff --git a/arch/ia64/configs/tiger_defconfig b/arch/ia64/configs/tiger_defconfig
> index a5a9e02..0f4e9e4 100644
> --- a/arch/ia64/configs/tiger_defconfig
> +++ b/arch/ia64/configs/tiger_defconfig
> @@ -31,7 +31,7 @@ CONFIG_ACPI_BUTTON=m
>  CONFIG_ACPI_FAN=m
>  CONFIG_ACPI_PROCESSOR=m
>  CONFIG_ACPI_CONTAINER=m
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_ACPI=m
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> diff --git a/arch/ia64/configs/xen_domu_defconfig b/arch/ia64/configs/xen_domu_defconfig
> index 37b9b42..b025acf 100644
> --- a/arch/ia64/configs/xen_domu_defconfig
> +++ b/arch/ia64/configs/xen_domu_defconfig
> @@ -32,7 +32,7 @@ CONFIG_ACPI_BUTTON=m
>  CONFIG_ACPI_FAN=m
>  CONFIG_ACPI_PROCESSOR=m
>  CONFIG_ACPI_CONTAINER=m
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_ACPI=m
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
> index c86fcb9..0e8cfd0 100644
> --- a/arch/powerpc/configs/ppc64_defconfig
> +++ b/arch/powerpc/configs/ppc64_defconfig
> @@ -58,7 +58,7 @@ CONFIG_SCHED_SMT=y
>  CONFIG_PPC_DENORMALISATION=y
>  CONFIG_PCCARD=y
>  CONFIG_ELECTRA_CF=y
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_RPA=m
>  CONFIG_HOTPLUG_PCI_RPA_DLPAR=m
>  CONFIG_PACKET=y
> diff --git a/arch/powerpc/configs/ppc64e_defconfig b/arch/powerpc/configs/ppc64e_defconfig
> index 4b20f76..0085dc4 100644
> --- a/arch/powerpc/configs/ppc64e_defconfig
> +++ b/arch/powerpc/configs/ppc64e_defconfig
> @@ -32,7 +32,7 @@ CONFIG_IRQ_ALL_CPUS=y
>  CONFIG_SPARSEMEM_MANUAL=y
>  CONFIG_PCI_MSI=y
>  CONFIG_PCCARD=y
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
>  CONFIG_XFRM_USER=m
> diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
> index bea8587..1d4b976 100644
> --- a/arch/powerpc/configs/pseries_defconfig
> +++ b/arch/powerpc/configs/pseries_defconfig
> @@ -53,7 +53,7 @@ CONFIG_PPC_64K_PAGES=y
>  CONFIG_PPC_SUBPAGE_PROT=y
>  CONFIG_SCHED_SMT=y
>  CONFIG_PPC_DENORMALISATION=y
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_HOTPLUG_PCI_RPA=m
>  CONFIG_HOTPLUG_PCI_RPA_DLPAR=m
>  CONFIG_PACKET=y
> diff --git a/arch/sh/configs/sh03_defconfig b/arch/sh/configs/sh03_defconfig
> index 2051821..0cf4097 100644
> --- a/arch/sh/configs/sh03_defconfig
> +++ b/arch/sh/configs/sh03_defconfig
> @@ -22,7 +22,7 @@ CONFIG_PREEMPT=y
>  CONFIG_CMDLINE_OVERWRITE=y
>  CONFIG_CMDLINE="console=ttySC1,115200 memdM root=/dev/nfs"
>  CONFIG_PCI=y
> -CONFIG_HOTPLUG_PCI=m
> +CONFIG_HOTPLUG_PCI=y
>  CONFIG_BINFMT_MISC=y
>  CONFIG_NET=y
>  CONFIG_PACKET=y
> diff --git a/drivers/pci/hotplug/Kconfig b/drivers/pci/hotplug/Kconfig
> index bb7ebb2..d85009d 100644
> --- a/drivers/pci/hotplug/Kconfig
> +++ b/drivers/pci/hotplug/Kconfig
> @@ -3,16 +3,13 @@
>  #
>  
>  menuconfig HOTPLUG_PCI
> -	tristate "Support for PCI Hotplug"
> +	bool "Support for PCI Hotplug"
>  	depends on PCI && SYSFS
>  	---help---
>  	  Say Y here if you have a motherboard with a PCI Hotplug controller.
>  	  This allows you to add and remove PCI cards while the machine is
>  	  powered up and running.
>  
> -	  To compile this driver as a module, choose M here: the
> -	  module will be called pci_hotplug.
> -
>  	  When in doubt, say N.
>  
>  if HOTPLUG_PCI
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

  reply	other threads:[~2013-07-25 19:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 17:57 [PATCH 0/2] PCI: Convert hotplug core and pciehp to be builtin only Bjorn Helgaas
2013-07-25 17:57 ` [PATCH 1/2] PCI: hotplug: Convert to be builtin only, not modular Bjorn Helgaas
2013-07-25 19:34   ` Rafael J. Wysocki [this message]
2013-07-26 12:42   ` Yinghai Lu
2013-07-25 17:57 ` [PATCH 2/2] PCI: pciehp: Convert pciehp " Bjorn Helgaas
2013-07-26 12:43   ` Yinghai Lu
2015-05-27 18:31     ` Yinghai Lu
2015-05-27 19:31       ` Bjorn Helgaas
2015-05-28  1:30         ` Rafael J. Wysocki
2015-05-28 22:08           ` Yinghai Lu
2015-05-28 22:19             ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1790250.TtZ9d6PaXM@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=fenghua.yu@intel.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tony.luck@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).