From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7794: alt: Enable ethernet controller
Date: Tue, 27 Jan 2015 08:55:22 +0000 [thread overview]
Message-ID: <1818612.14pAH37Kz1@avalon> (raw)
In-Reply-To: <1422348356-18675-2-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
Hi Geert,
Thank you for the review.
On Tuesday 27 January 2015 09:53:25 Geert Uytterhoeven wrote:
> On Tue, Jan 27, 2015 at 9:45 AM, Laurent Pinchart wrote:
> > Enable the ethernet controller for the Alt board. Pin muxing entries are
> > currently left out as r8a7794 pin control support isn't available yet.
> > We thus rely on the boot loader to configure ethernet pins for now.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
>
> Looks OK (I don't have an Alt, nor schematics).
I only have a block diagram, no detailed schematics. I have however
successfully tested the patch on Magnus' Alt board. It might depends on
particular DIP switch settings, but it should be good enough to start with.
> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-01-27 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 8:45 [PATCH 2/2] ARM: shmobile: r8a7794: alt: Enable ethernet controller Laurent Pinchart
2015-01-27 8:53 ` Geert Uytterhoeven
2015-01-27 8:55 ` Laurent Pinchart [this message]
2015-01-28 6:48 ` Simon Horman
2015-02-03 21:43 ` Sergei Shtylyov
2015-02-04 17:29 ` Laurent Pinchart
2015-02-04 17:38 ` Sergei Shtylyov
2015-02-04 18:12 ` Geert Uytterhoeven
2015-02-04 18:18 ` Sergei Shtylyov
2015-02-04 19:37 ` Sergei Shtylyov
2015-02-05 12:17 ` Laurent Pinchart
2015-02-05 12:35 ` Sergei Shtylyov
2015-02-05 14:47 ` Laurent Pinchart
2015-02-09 14:36 ` Stephen Lawrence
2015-02-09 17:05 ` Laurent Pinchart
2015-02-09 17:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1818612.14pAH37Kz1@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).