From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Linux-sh list <linux-sh@vger.kernel.org>
Subject: Re: [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter
Date: Sun, 26 Oct 2014 14:43:52 +0000 [thread overview]
Message-ID: <1841308.v8gkVZqzX1@avalon> (raw)
In-Reply-To: <CAMuHMdXF_m2gK2qYvExhAS-J4TXjv8f-5X0bAq--PswAsgjbnA@mail.gmail.com>
Hi Geert,
Thank you for the review.
On Friday 24 October 2014 15:58:34 Geert Uytterhoeven wrote:
> On Fri, Oct 24, 2014 at 2:58 PM, Laurent Pinchart
>
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > --- a/include/drm/drm_edid.h
> > +++ b/include/drm/drm_edid.h
> > @@ -279,4 +279,8 @@ int
> > drm_hdmi_vendor_infoframe_from_display_mode(struct hdmi_vendor_infoframe
> > *frame,
> > const struct drm_display_mode
> > *mode);
> > +struct edid *drm_do_get_edid(struct drm_connector *connector,
> > + int (*get_edid_block)(void *, u8 *buf, unsigned int, size_t),
>
> It doesn't hurt to add parameter names for all parameters, as hints
> for implementors.
Good point, I'll fix that.
> > + void *data);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-10-26 14:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:58 [PATCH v2 0/9] Renesas R-Car DU HDMI support Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 1/9] drm: rcar-du: Remove platform data support Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 2/9] drm: rcar-du: Pass the encoder DT node to rcar_du_encoder_init() Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 3/9] drm: rcar-du: Replace direct DRM encoder access with cast macro Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 4/9] drm: rcar-du: Replace drm_encoder with drm_slave_encoder Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 5/9] drm: rcar-du: Add HDMI encoder and connector support Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 6/9] drm: Decouple EDID parsing from I2C adapter Laurent Pinchart
2014-10-24 13:58 ` Geert Uytterhoeven
2014-10-26 14:43 ` Laurent Pinchart [this message]
2014-10-24 12:58 ` [PATCH v2 7/9] video: Add ADV751[13] DT bindings documentation Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 8/9] drm: Add adv7511 encoder driver Laurent Pinchart
2014-10-24 12:58 ` [PATCH v2 9/9] ARM: shmobile: koelsch: Add DU HDMI output support Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1841308.v8gkVZqzX1@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox