From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1
Date: Sat, 23 May 2015 19:09:29 +0000 [thread overview]
Message-ID: <1894468.fs1e2s7WTP@avalon> (raw)
In-Reply-To: <1432145174-11534-5-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Wednesday 20 May 2015 20:06:10 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/tty/serial/sh-sci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 21c07c6cb0cd2220..73f4115159a7fbbc 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -960,7 +960,8 @@ static irqreturn_t sci_rx_interrupt(int irq, void *ptr)
> }
> serial_port_out(port, SCSCR, scr);
> /* Clear current interrupt */
> - serial_port_out(port, SCxSR, ssr & ~(1 | SCxSR_RDxF(port)));
> + serial_port_out(port, SCxSR,
> + ssr & ~(SCIF_DR | SCxSR_RDxF(port)));
> dev_dbg(port->dev, "Rx IRQ %lu: setup t-out in %u jiffies\n",
> jiffies, s->rx_timeout);
> mod_timer(&s->rx_timer, jiffies + s->rx_timeout);
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2015-05-23 19:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 18:06 [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1 Geert Uytterhoeven
2015-05-23 19:09 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1894468.fs1e2s7WTP@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox