Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Add alternative MSIOF pin groups

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

On Tuesday 25 February 2014 18:50:21 Geert Uytterhoeven wrote:
> On Tue, Feb 25, 2014 at 6:19 PM, Laurent Pinchart wrote:
> >> +static const unsigned int msiof1_rx_d_pins[] = {
> >> +     /* RXD */
> >> +     RCAR_GP_PIN(0, 26),
> > 
> > This should be (0, 27).
> 
> Wow, nice catch. Thanks a lot!

You're welcome. This is why I dislike reviewing PFC patches though, it's lots 
of small numbers that need to be checked.

> >> +static const unsigned int msiof2_ss2_d_pins[] = {
> >> +     /* SS2 */
> >> +     RCAR_GP_PIN(2, 18),
> > 
> > This should be (2, 19).
> 
> p. 4-16 of Rev. 0.31 of the R-Car M2 datasheet states that GP2_18 can be
> both MSIOF2_SS2_D (function 3) and MSIOF2_RXD_D (function 5),
> but p. 5-37 disagrees?
> It seems the whole function 3 column on p. 4-16 is offset by one,
> compared to p. 5-37.
> 
> Well, (2, 19) sounds more logical, so let's assume p. 5-37 is correct for
> now.

Sounds good to me.

> > > +};
> > > +static const unsigned int msiof2_ss2_d_mux[] = {
> > > +     MSIOF2_SS2_D_MARK,
> > > +};
> > > +static const unsigned int msiof2_rx_d_pins[] = {
> > > +     /* RXD */
> > > +     RCAR_GP_PIN(2, 18),
> > > +};

-- 
Regards,

Laurent Pinchart