From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 30 Jul 2013 09:42:44 +0000 Subject: Re: [PATCH v2 2/2] ARM: shmobile: ape6evm-reference: add MMCIF and SDHI DT nodes Message-Id: <1928419.65G7q6A4Po@avalon> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Simon and Guennadi, On Tuesday 30 July 2013 11:23:06 Simon Horman wrote: > On Tue, Jul 23, 2013 at 01:19:14PM +0200, Guennadi Liakhovetski wrote: > > This patch adds MMCIF0, SDHI0 and SDHI1 DT nodes and a fixed voltage > > reglator for them to the ape6evm-reference platform. > > Magnus or Laurent, could you please review this? Sure. > > Signed-off-by: Guennadi Liakhovetski > > --- > > > > v2: also add a regulator > > > > arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts | 51 ++++++++++++++++++ > > 1 files changed, 51 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts > > b/arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts index bbd09d8..74a2e1c > > 100644 > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts > > @@ -24,6 +24,14 @@ > > reg = <0 0x40000000 0 0x40000000>; > > }; > > > > + ape6evm_fixed_3v3: fixedregulator@0 { > > + compatible = "regulator-fixed"; > > + regulator-name = "3V3"; > > + regulator-min-microvolt = <3300000>; > > + regulator-max-microvolt = <3300000>; > > + regulator-always-on; > > + }; > > + > > lbsc { > > compatible = "simple-bus"; > > #address-cells = <1>; > > @@ -62,4 +70,47 @@ > > renesas,groups = "scifa0_data"; > > renesas,function = "scifa0"; > > }; > > + > > + mmc0_pins: mmcif { > > + renesas,groups = "mmc0_data8", "mmc0_ctrl"; > > + renesas,function = "mmc0"; > > + }; > > + > > + sdhi0_pins: sdhi0 { > > + renesas,groups = "sdhi0_data4", "sdhi0_ctrl", "sdhi0_cd"; > > + renesas,function = "sdhi0"; > > + }; > > + > > + sdhi1_pins: sdhi1 { > > + renesas,groups = "sdhi1_data4", "sdhi1_ctrl"; > > + renesas,function = "sdhi1"; > > + }; > > +}; > > + > > +&mmcif0 { > > + vmmc-supply = <&ape6evm_fixed_3v3>; > > + bus-width = <8>; > > + non-removable; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&mmc0_pins>; > > + status = "okay"; > > +}; According to the APE6EVM datasheet, the eMMC power supply is 2.8V, not 3.3V. Could you please verify that ? I don't think the power supply can be GPIO- controlled by I might have overlooked something, could you please also verify that ? > > +&sdhi0 { > > + vmmc-supply = <&ape6evm_fixed_3v3>; > > + bus-width = <4>; > > + toshiba,mmc-wrprotect-disable; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sdhi0_pins>; > > + status = "okay"; > > +}; SDHI0 seems to be powered by a GPIO-controller regulator (on port 76). Could you please verify that and update the patch accordingly ? > > +&sdhi1 { > > + vmmc-supply = <&ape6evm_fixed_3v3>; > > + bus-width = <4>; > > + broken-cd; > > + toshiba,mmc-wrprotect-disable; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&sdhi1_pins>; > > + status = "okay"; > > > > }; -- Regards, Laurent Pinchart