Re: [PATCH v3 2/4] ARM: shmobile: lager-reference: Add DU device

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Simon,

On Monday 17 February 2014 12:09:32 Simon Horman wrote:
> On Sun, Feb 16, 2014 at 10:31:59PM +0100, Laurent Pinchart wrote:
> > The DU device has no DT bindings yet, instantiate it as a platform
> > device for now.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > Acked-by: Magnus Damm <damm@opensource.se>
> 
> Hi Laurent,
> 
> thanks for this.
> 
> It seems to me that it would be best to split this patch into two,
> a board portion and a dt portion, so that each patche can
> be applied to their respective branch.
> 
> In order to save you the bother of resending the series yet another time
> I have taken the liberty of splitting the patch into two. The following
> is the DTS patch. The remainder of your patch was taken (otherwise
> unchanged) as the boards patch,

That's fine with me, but we should make sure to merge the DT change first, 
otherwise DU will be broken between the two patches.

> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 
> ARM: shmobile: lager: Add DU device to DTS
> 
> The DU device has no DT bindings yet, instantiate it as a platform
> device for now.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Acked-by: Magnus Damm <damm@opensource.se>
> [horms+renesas@verge.net.au: broken out of larger patch that
>                              included board changes]
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm/boot/dts/r8a7790-lager.dts | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index 5466fe4..26a9010 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -111,9 +111,14 @@
>  };
> 
>  &pfc {
> -	pinctrl-0 = <&scif0_pins &scif1_pins>;
> +	pinctrl-0 = <&du_pins &scif0_pins &scif1_pins>;
>  	pinctrl-names = "default";
> 
> +	du_pins: du {
> +		renesas,groups = "du_rgb666", "du_sync_1", "du_clk_out_0";
> +		renesas,function = "du";
> +	};
> +
>  	scif0_pins: serial0 {
>  		renesas,groups = "scif0_data";
>  		renesas,function = "scif0";

-- 
Regards,

Laurent Pinchart