SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC] ARM: shmobile: koelsch: activate i2c6 bus
Date: Sun, 23 Feb 2014 19:26:01 +0000	[thread overview]
Message-ID: <1944985.uR4APBXffS@avalon> (raw)
In-Reply-To: <1393159437-14456-1-git-send-email-wsa@the-dreams.de>

Hi Wolfram,

Thank you for the patch.

On Sunday 23 February 2014 13:43:57 Wolfram Sang wrote:
> From: Wolfram Sang <wsa@sang-engineering.com>
> 
> Signed-off-by: Wolfram Sang <wsa@sang-engineering.com>
> ---
> 
> I used this patch to test my IIC(B) enablement patches. With i2ctools,  I
> could scan this bus and read registers from the connected pmic. Actually, I
> don't think we should expose this bus unless really needed, but maybe you
> think different?

The I2C6 bus signals are routed to an extension connector as well as to the 
DA9063 PMIC and DA9210 sub-PMIC. There's no urgent need to enable it now as we 
don't instantiate support the PMIC and sub-PMIC at the moment. However, as 
we'll have to enable it anyway,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Is anyone working on PMIC support for the Koelsch board ? The DA9063 and 
DA9210 have drivers in mainline. They might not support all the features we 
need, but limited support shouldn't be difficult.

>  arch/arm/boot/dts/r8a7791-koelsch.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> b/arch/arm/boot/dts/r8a7791-koelsch.dts index e6ca0e0..4557f8e 100644
> --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> @@ -122,6 +122,11 @@
>  	};
>  };
> 
> +&i2c6 {
> +	status = "okay";
> +	clock-frequency = <100000>;
> +};
> +
>  &pfc {
>  	pinctrl-0 = <&du_pins &scif0_pins &scif1_pins>;
>  	pinctrl-names = "default";

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2014-02-23 19:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-23 12:43 [RFC] ARM: shmobile: koelsch: activate i2c6 bus Wolfram Sang
2014-02-23 19:26 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1944985.uR4APBXffS@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox