* [PATCH] drivers/media: vsp1_video: fix compile error
@ 2016-01-15 0:09 Anders Roxell
2016-01-24 22:15 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2016-01-15 0:09 UTC (permalink / raw)
To: mchehab, laurent.pinchart
Cc: linux-media, linux-sh, linux-kernel, linux-rt-users,
Anders Roxell
This was found with the -RT patch enabled, but the fix should apply to
non-RT also.
Compilation error without this fix:
../drivers/media/platform/vsp1/vsp1_video.c: In function
'vsp1_pipeline_stopped':
../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
expression before 'do'
spin_unlock_irqrestore(&pipe->irqlock, flags);
^
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/media/platform/vsp1/vsp1_video.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index 637d0d6..b4dca57 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline *pipe)
bool stopped;
spin_lock_irqsave(&pipe->irqlock, flags);
- stopped = pipe->state = VSP1_PIPELINE_STOPPED,
+ stopped = pipe->state = VSP1_PIPELINE_STOPPED;
spin_unlock_irqrestore(&pipe->irqlock, flags);
return stopped;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drivers/media: vsp1_video: fix compile error
2016-01-15 0:09 [PATCH] drivers/media: vsp1_video: fix compile error Anders Roxell
@ 2016-01-24 22:15 ` Laurent Pinchart
2016-01-25 11:14 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2016-01-24 22:15 UTC (permalink / raw)
To: Anders Roxell
Cc: mchehab, linux-media, linux-sh, linux-kernel, linux-rt-users
Hi Anders,
Thank you for the patch.
On Friday 15 January 2016 01:09:43 Anders Roxell wrote:
> This was found with the -RT patch enabled, but the fix should apply to
> non-RT also.
>
> Compilation error without this fix:
> ../drivers/media/platform/vsp1/vsp1_video.c: In function
> 'vsp1_pipeline_stopped':
> ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
> expression before 'do'
> spin_unlock_irqrestore(&pipe->irqlock, flags);
> ^
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline
> *pipe) bool stopped;
>
> spin_lock_irqsave(&pipe->irqlock, flags);
> - stopped = pipe->state = VSP1_PIPELINE_STOPPED,
> + stopped = pipe->state = VSP1_PIPELINE_STOPPED;
> spin_unlock_irqrestore(&pipe->irqlock, flags);
>
> return stopped;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/media: vsp1_video: fix compile error
2016-01-24 22:15 ` Laurent Pinchart
@ 2016-01-25 11:14 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2016-01-25 11:14 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Anders Roxell, linux-media, linux-sh, linux-kernel,
linux-rt-users
Em Mon, 25 Jan 2016 00:15:28 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Hi Anders,
>
> Thank you for the patch.
>
> On Friday 15 January 2016 01:09:43 Anders Roxell wrote:
> > This was found with the -RT patch enabled, but the fix should apply to
> > non-RT also.
> >
> > Compilation error without this fix:
> > ../drivers/media/platform/vsp1/vsp1_video.c: In function
> > 'vsp1_pipeline_stopped':
> > ../drivers/media/platform/vsp1/vsp1_video.c:524:2: error: expected
> > expression before 'do'
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> > ^
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> and applied to my tree.
Better to apply this to the fixes branch and send it together with
the next set of patches upstream.
>
> > ---
> > drivers/media/platform/vsp1/vsp1_video.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/vsp1/vsp1_video.c
> > b/drivers/media/platform/vsp1/vsp1_video.c index 637d0d6..b4dca57 100644
> > --- a/drivers/media/platform/vsp1/vsp1_video.c
> > +++ b/drivers/media/platform/vsp1/vsp1_video.c
> > @@ -515,7 +515,7 @@ static bool vsp1_pipeline_stopped(struct vsp1_pipeline
> > *pipe) bool stopped;
> >
> > spin_lock_irqsave(&pipe->irqlock, flags);
> > - stopped = pipe->state = VSP1_PIPELINE_STOPPED,
> > + stopped = pipe->state = VSP1_PIPELINE_STOPPED;
> > spin_unlock_irqrestore(&pipe->irqlock, flags);
> >
> > return stopped;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-25 11:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 0:09 [PATCH] drivers/media: vsp1_video: fix compile error Anders Roxell
2016-01-24 22:15 ` Laurent Pinchart
2016-01-25 11:14 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).