Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

Paul Mundt
2007-12-28T03:41:36Z

On Thu, Dec 27, 2007 at 07:49:01PM -0500, Mike Frysinger wrote:
> On Thursday 27 December 2007, Joe Perches wrote:
> > I also added a function gdrom_is_busy() to make a couple of tests
> > fit on a single line and perhaps easier to read.
>
> i'd tend to agree it does make it easier to read, however you didnt make it
> inline which means gcc may not inline it which means there's pointless
> overhead of doing a function call.
>
These days GCC is usually smart enough to automatically inline things
that are that small, it doesn't need to be explicitly labelled. If your
toolchain doesn't inline that gdrom_is_busy() implementation, get a
better toolchain.

> otherwise, arbitrary breaking on 80 cols actually makes the code harder to
> read for no gain.

Hey now, some of us have no intention of giving up our 80x25 consoles,
not everyone buys in to this whole newfangled X thing. ;-)

More than 80 columns is generally fine so long as it's done so tastefully
rather than arbitrarily based on a larger console width. However, if it
can be split up cleanly for 80 columns, then it should be. ie, use common
sense, rather than blindly adhering to the whims of an anal-retentive
script.