Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

Mike Frysinger
2007-12-28T00:49:01Z

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

On Thursday 27 December 2007, Joe Perches wrote:
> On Thu, 2007-12-27 at 16:52 +0000, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.

for the 80 col limit, that's up to the author. if Adrian is happy with it as
is, that's fine.

> I also added a function gdrom_is_busy() to make a couple of tests
> fit on a single line and perhaps easier to read.

i'd tend to agree it does make it easier to read, however you didnt make it
inline which means gcc may not inline it which means there's pointless
overhead of doing a function call.

otherwise, arbitrary breaking on 80 cols actually makes the code harder to
read for no gain.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]