Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

Paul Mundt
2008-01-16T01:57:37Z

On Sat, Jan 12, 2008 at 05:36:30AM -0800, Andrew Morton wrote:
> On Fri, 11 Jan 2008 21:56:49 +0000 Adrian McMenamin <adrian@newgolddream.dyndns.info> wrote:
> > +/* keep the function looking like the universal CD Rom specification - returning int*/
> > +static int gdrom_packetcommand(struct cdrom_device_info *cd_info, struct packet_command *command)
> > +{
> > + gdrom_spicommand(&command->cmd, command->buflen);
> > + return 0;
> > +}
>
> Please pass the diff through scripts/checkpatch.pl. Some things, like the
> above, you may choose to fix. Some you definitely will.

On Tue, Jan 15, 2008 at 08:41:39PM +0000, Adrian McMenamin wrote:
> On 15/01/2008, Paul Mundt <lethal@linux-sh.org> wrote:
> > On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote:
>
> >
> > > +static bool gdrom_data_request(void)
> > > +{
> > > + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;
> > > +}
> > > +
> > Andrew first pointed this out, and this is still broken.
> >
>
> Eh, no, he didn't. What is wrong with it?
>
Quoted above for your convenience.

> He compalined about excessively long busy waiting and then not
> checking if the busy wait failed. Both those have been fixed.

This was also covered in the checkpatch output that you conveniently
trimmed in your reply. If you can't see the problem, either your version
of checkpatch or your editor are broken. Huge amounts of your patch
continue to be whitespace damaged, and while you claim to have fixed
that, checkpatch continually whines about the same thing in each
iteration of your patch. Please just fix it up instead of arguing about
it, thanks.