Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

Paul Mundt
2007-12-31T05:23:36Z

On Sun, Dec 30, 2007 at 01:38:24PM +0000, Adrian McMenamin wrote:
> On Thu, 2007-12-27 at 14:58 -0800, Joe Perches wrote:
> > On Thu, 2007-12-27 at 16:52 +0000, Adrian McMenamin wrote:
> > > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
> >
> > Because it was already so close, might as well make it checkpatch clean.
> >
> > I also added a function gdrom_is_busy() to make a couple of tests
> > fit on a single line and perhaps easier to read.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> >
> Not really for me to decide if this gets applied - I'll leave that to
> Paul as the maintainer. But I have no objection to them :)

Both patches are fine with me, but it is ultimately Jens (as the
drivers/cdrom authority) that will have to decide whether to sign off on
the GDROM patches or not, and through which tree the patches will end up
being merged. I can certainly merge them through my tree with his
Acked-by if that's deemed the most convenient.