Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

Adrian McMenamin
2008-01-15T20:41:39Z

On 15/01/2008, Paul Mundt <lethal@linux-sh.org> wrote:
> On Mon, Jan 14, 2008 at 11:17:15PM +0000, Adrian McMenamin wrote:

>
> > +static bool gdrom_data_request(void)
> > +{
> > + return (ctrl_inb(GDROM_ALTSTATUS_REG) & 0x88) = 8;
> > +}
> > +
> Andrew first pointed this out, and this is still broken.
>

Eh, no, he didn't. What is wrong with it?

He compalined about excessively long busy waiting and then not
checking if the busy wait failed. Both those have been fixed.