From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Add SH Ethernet platform device for Solution Engine
Date: Fri, 18 Jan 2008 09:06:05 +0000 [thread overview]
Message-ID: <20080118090605.GA25652@linux-sh.org> (raw)
In-Reply-To: <479065E5.70109@renesas.com>
On Fri, Jan 18, 2008 at 05:40:05PM +0900, Yoshihiro Shimoda wrote:
> @@ -115,9 +116,61 @@ static struct platform_device heartbeat_
> .resource = heartbeat_resources,
> };
>
> +#if defined(CONFIG_SH_ETH)
> +static struct resource sh_eth0_resources[] = {
> + [0] = {
> + .start = SH_ETH0_BASE,
> + .end = SH_ETH0_BASE + 0x1B8,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = IRQ_SH_ETH0,
> + .end = IRQ_SH_ETH0,
> + .flags = IORESOURCE_IRQ,
> + },
> +};
Do not use ifdefs for platform devices. If they are unclaimed, they are
freed up due to being __initdata. ifdefs just make the code ugly.
Also, there's no point in merging the board stuff until the driver itself
has been merged. If people are going to keep the ethernet driver out of
tree, then the patch adding it to the board can go along with it.
prev parent reply other threads:[~2008-01-18 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-18 8:40 [PATCH] sh: Add SH Ethernet platform device for Solution Engine Yoshihiro Shimoda
2008-01-18 9:06 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080118090605.GA25652@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox