Re: [PATCH] spi: add support for SPI over SuperH SCI pins

David Brownell
2008-01-22T04:38:48Z

On Monday 21 January 2008, Magnus Damm wrote:
> On Jan 22, 2008 7:29 AM, David Brownell <david-b@pacbell.net> wrote:
> >
> > You should consider adding yourself to MAINTAINERS for
> > this driver...
>
> Yes. If it's ok with you then i'll send a separate patch for that. I
> should probably add more than one entry there.

Fine by me.

> > > + /* register the chips to go with the board */
> > > +
> > > + for (i = 0; i < sp->info->board_size; i++) {
> > > + dev_info(&dev->dev, "registering %p: %s\n",
> > > + &sp->info->board_info[i],
> > > + sp->info->board_info[i].modalias);
> > > +
> > > + sp->info->board_info[i].controller_data = sp;
> > > + spi_new_device(master, sp->info->board_info + i);
> >
> > NO -- this doesn't belong here at all. Such registration is handled
> > by the SPI core code, according to what the board init code told it.
>
> Hehe. My gut reaction was the same when i read the s3c24xx drivers,

Gaak. How did those get in with such crap?

Aaaah, I see ... I never signed off on their original merge. Hmm.

> but then I decided to follow their style. I'll remove that part then
> and instead register the spi devices from the board code using
> spi_register_board_info().
>
> I'll fix up the code and repost in a bit. Thanks for your review!

Sure.

- Dave