Re: [PATCH] spi: add support for SPI over SuperH SCI pins

[Paul Mundt <lethal@linux-sh.org>]

On Mon, Jan 21, 2008 at 02:29:29PM -0800, David Brownell wrote:
> On Monday 21 January 2008, Magnus Damm wrote:
> > +struct sh_sci_spi {
> > +	struct spi_bitbang bitbang;
> > +
> > +	unsigned long mapbase;
> 
> Not "void __iomem *mapbase"?
> 
> I notice that you're not doing an ioremap() to get this address.
> Is the platform device properly registering a *physical* address
> in the IORESOURCE_MEM record for the device?
> 
It should be ioremap(), yes. While for these parts ioremap() doesn't
really do anything, it still takes care of the void __iomem * casting
properly, and there are in fact parts where we have no choice but to go
through page tables anyways.

> > +#define spidelay(x) ndelay(x)
> > +
> > +#define	EXPAND_BITBANG_TXRX
> > +#include <linux/spi/spi_bitbang.h>
> > +

This is rather unorthodox..